Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Braintree] Added unit test for instant purchase PayPal token formatter #17472

Merged
merged 1 commit into from
Aug 11, 2018
Merged

[Forwardport] [Braintree] Added unit test for instant purchase PayPal token formatter #17472

merged 1 commit into from
Aug 11, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Aug 9, 2018

Original Pull Request

#17405

Description

This PR adds unit test with different scenarios for \Magento\Braintree\Test\Unit\Model\InstantPurchase\Paypal\TokenFormatterTest class.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Aug 9, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2727 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 63a1058 into magento:2.3-develop Aug 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants