Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused ID #17291

Merged
merged 4 commits into from Aug 2, 2018
Merged

fix: remove unused ID #17291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9055f7d
fix: remove unused ID
Jul 31, 2018
e2b73b4
chore: move class to data-form attribute
Aug 1, 2018
5266a0c
Remove unneeded "form" form data-form attribute value
orlangur Aug 1, 2018
4a3a0ec
Remove unneeded "form" form data-form attribute value
orlangur Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Checkout/Test/Mftf/Section/CheckoutPaymentSection.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<element name="isPaymentSection" type="text" selector="//*[@class='opc-progress-bar']/li[contains(@class, '_active') and span[contains(.,'Review &amp; Payments')]]"/>
<element name="availablePaymentSolutions" type="text" selector="#checkout-payment-method-load>div>div>div:nth-child(2)>div.payment-method-title.field.choice"/>
<element name="notAvailablePaymentSolutions" type="text" selector="#checkout-payment-method-load>div>div>div.payment-method._active>div.payment-method-title.field.choice"/>
<element name="billingNewAddressForm" type="text" selector=".billing-new-address-form"/>
<element name="billingNewAddressForm" type="text" selector="[data-form='billing-new-address']"/>
<element name="placeOrderDisabled" type="button" selector="#checkout-payment-method-load button.disabled"/>
<element name="update" type="button" selector=".payment-method-billing-address .action.action-update"/>
<element name="guestFirstName" type="input" selector=".billing-address-form input[name*='firstname']"/>
Expand Down
4 changes: 1 addition & 3 deletions app/code/Magento/Checkout/view/frontend/web/template/billing-address/form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
<!-- ko template: getTemplate() --><!-- /ko -->
<!--/ko-->
<form data-bind="attr: {'data-hasrequired': $t('* Required Fields')}">
<fieldset
data-bind="attr: { id:'billing-new-address-form-'+index, value:index}"
class="billing-new-address-form fieldset address">
<fieldset class="fieldset address" data-form="billing-new-address">
<!-- ko foreach: getRegion('additional-fieldsets') -->
<!-- ko template: getTemplate() --><!-- /ko -->
<!--/ko-->
Expand Down