Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Refactor JavsScript for customer logout #15752

Merged
merged 2 commits into from
Jun 5, 2018
Merged

[Forwardport] Refactor JavsScript for customer logout #15752

merged 2 commits into from
Jun 5, 2018

Conversation

vijay-wagento
Copy link

Original Pull Request

#15301
Refactor JavaScript for front-end customer logout

Description

Remove JavaScript from logout.phtml and create JS component for that.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. Login in front-end
  2. Logout from front-end

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Customer labels Jun 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
@magento-engcom-team magento-engcom-team merged commit 2922332 into magento:2.3-develop Jun 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2018
@VladimirZaets
ENGCOM-1822: [Forwardport] Refactor JavsScript for customer logout #1…
a4c2f2e 
…5752
@magento-engcom-team
Copy link
Contributor

Hi @vijay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Component: Customer Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vijay-wagento @magento-engcom-team @VladimirZaets @patelnimesh1988