Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] fixed Submitting search form (mini) with enter key fires event handle… #15696

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#15340

Description

When submitting the search form in the header with the enter key on the keyboard, event handlers that were bound to the form submit (through jQuery) are fired twice.

Fixed Issues (if relevant)

  1. Submitting search form (mini) with enter key fires event handlers bound by jquery twice #13793: Submitting search form (mini) with enter key fires event handlers bound by jquery twice

Manual testing scenarios

  1. Create a javascript which adds an event handler to the form submit
  2. $('#search_mini_form').on('submit', function(e) {
    console.log('listening for form submit');
    });
  3. Submit the search form in the header with a value by pressing the enter button

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants