[fix] typo in method name _getCharg[e]ableOptionPrice #15276
Conversation
|
Hi @miguelbalparda, thank you for the review. |
| * | ||
| * @param float $price Price of option | ||
| * @param boolean $isPercent Price type - percent or fixed | ||
| * @param float $basePrice For percent price type | ||
| * @return float | ||
| */ | ||
| protected function _getChargableOptionPrice($price, $isPercent, $basePrice) | ||
| protected function _getChargeableOptionPrice($price, $isPercent, $basePrice) |
There was a problem hiding this comment.
Protected methods cannot be removed, please check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#php:
Public and protected method removal
Mark the method with the@deprecatedtag instead of removing it.
There was a problem hiding this comment.
Protected methods cannot be removed, please check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html
|
Hi @mhauri. Thank you for your contribution. Please, consider porting this solution across release lines. |
Description
Method name
\Magento\Catalog\Model\Product\Option\Type::_getChargableOptionPricecontained typo.Renamed it to
_getChargeableOptionPrice.Contribution checklist