Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMOPS-908: Updating compatibility with the BIC doc generator #25

Merged
merged 2 commits into from
Feb 27, 2020
Merged

COMOPS-908: Updating compatibility with the BIC doc generator #25

merged 2 commits into from
Feb 27, 2020

Conversation

pdohogne-magento
Copy link
Contributor

@pdohogne-magento pdohogne-magento commented Feb 21, 2020 •
edited by roribio
Loading

Description

COMOPS-908: BIC Doc Tool enhancements

  • Made magento-semver more inheritance-friendly to allow the BIC Doc Generator tool to automatically pull in any new rules/analyzers added to magento-semver

Manual testing scenarios

  1. Run the BIC Doc Generator job against this and the associated internal PR and examine the resulting PR in the magento/devdocs repo

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

irenelagno
irenelagno reviewed Feb 25, 2020
View reviewed changes
irenelagno
irenelagno reviewed Feb 25, 2020
View reviewed changes
@pdohogne-magento pdohogne-magento force-pushed the COMOPS-908-BIC-doc-generator branch 3 times, most recently from 348ec7d to 7994eb0 Compare February 26, 2020 20:34
@pdohogne-magento pdohogne-magento force-pushed the COMOPS-908-BIC-doc-generator branch from 7994eb0 to b04892c Compare February 26, 2020 20:36
@roribio roribio merged commit 2e19e12 into develop Feb 27, 2020
roribio added a commit that referenced this pull request Feb 27, 2020
@roribio @pdohogne-magento
SVC Release 3.0.0 (#27)
1eb776c 
* Update README.md: Add information about releases and versioning

* COMOPS-908: Updating compatibility with the BIC doc generator (#25)

* EQPS-477: SVC Enhancements (#26)

* EQPS-477: Dynamically set the correct path for autoload.php based on the location of the ‘vendor’ folder

* EQPS-477: Make zend-stdlib a required dependency

Co-authored-by: Peter Dohogne <pdohogne@adobe.com>
@roribio roribio deleted the COMOPS-908-BIC-doc-generator branch February 28, 2020 17:38
magento-cicd2 pushed a commit that referenced this pull request Apr 22, 2021
@zakdma
Merge pull request #25 from magento-tsg/MC-36160
c9485d2 
[Arrows] MC-36160: SVC false-positive: used a protected property from parents class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenelagno irenelagno irenelagno approved these changes

Assignees

@pdohogne-magento pdohogne-magento

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdohogne-magento @irenelagno @roribio