Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Redundant 'isset' should be omitted in resolvers #687

Closed
TomashKhamlai opened this issue May 8, 2019 · 2 comments
Closed

Redundant 'isset' should be omitted in resolvers #687

TomashKhamlai opened this issue May 8, 2019 · 2 comments
Labels
Component: CustomerGraphQl Component: QuoteGraphQl good first issue Good for newcomers
Milestone
Release: 2.3.3

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented May 8, 2019 •
edited by lenaorobei
Loading

Acceptance Criteria

Eliminate redundant !isset in CustomerGraphQl and QuoteGraphQl resolvers.

if (!isset($args['arg']) || empty($args['arg']))

Use empty($args['arg']) instead.
@TomashKhamlai TomashKhamlai added question Further information is requested Component: CustomerGraphQl labels May 8, 2019
@TomashKhamlai
Copy link
Contributor Author

@naydav, please validate (change labels if needed) and unassign issue

@lenaorobei lenaorobei changed the title Check that isset can be omitted in the public method Redundant 'isset' can be omitted in resolvers Jun 7, 2019
@lenaorobei lenaorobei added Component: QuoteGraphQl and removed question Further information is requested labels Jun 7, 2019
@lenaorobei lenaorobei changed the title Redundant 'isset' can be omitted in resolvers Redundant 'isset' should be omitted in resolvers Jun 7, 2019
@lenaorobei lenaorobei added the good first issue Good for newcomers label Jun 10, 2019
@larsroettig larsroettig self-assigned this Jun 20, 2019
larsroettig pushed a commit that referenced this issue Jun 20, 2019
#687 Remove Redundant 'isset'
aeec8f7
@larsroettig larsroettig mentioned this issue Jun 20, 2019
Merged
4 tasks
magento-engcom-team added a commit that referenced this issue Jun 21, 2019
@magento-engcom-team
ENGCOM-5327: #687 Remove Redundant 'isset' #749
41e424b 
 - Merge Pull Request #749 from magento/graphql-ce:687-Redundant-isset
 - Merged commits:
   1. aeec8f7
magento-engcom-team pushed a commit that referenced this issue Jun 21, 2019
@naydav
ENGCOM-5327: #687 Remove Redundant 'isset' #749
eec67e9
magento-engcom-team pushed a commit that referenced this issue Jun 21, 2019
@naydav
ENGCOM-5327: #687 Remove Redundant 'isset' #749
17cdb10
@naydav naydav added this to the Release: 2.3.3 milestone Jun 21, 2019
@naydav
Copy link
Contributor

naydav commented Jun 21, 2019

#749

@naydav naydav closed this as completed Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: CustomerGraphQl Component: QuoteGraphQl good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.3
Development

No branches or pull requests
4 participants
@naydav @larsroettig @TomashKhamlai @lenaorobei