Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

[Test coverage] Generate customer token #675

Closed
naydav opened this issue May 6, 2019 · 2 comments
Closed

[Test coverage] Generate customer token #675

naydav opened this issue May 6, 2019 · 2 comments
Assignees
@atwixfirster
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.3

Comments

@naydav
Copy link
Contributor

naydav commented May 6, 2019

Need to cover with API-functional tests cases in

generateCustomerToken(email: String!, password: String!): CustomerToken @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\GenerateCustomerToken") @doc(description:"Retrieve the customer token")

Test cases:

\Magento\GraphQl\Customer\GenerateCustomerTokenTest
- testGenerateCustomerTokenWithInvalidEmail (email is missed, email is empty)
- testGenerateCustomerTokenWithInvalidPassword (password is missed, password is empty)
- testRegenerateCustomerToken (should be different from initial token)

Examples:
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Customer
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

Guide:
https://devdocs.magento.com/guides/v2.3/graphql/functional-testing.html
@naydav naydav added good first issue Good for newcomers test-coverage Contribution Day Tickets is good for start on Contribution Day labels May 6, 2019
@naydav naydav added this to the Release: 2.3.3 milestone May 6, 2019
@atwixfirster atwixfirster self-assigned this May 6, 2019
atwixfirster added a commit that referenced this issue May 6, 2019
@atwixfirster
#675: [Test coverage] Generate customer token
aa23860
atwixfirster added a commit that referenced this issue May 6, 2019
@atwixfirster
#675: [Test coverage] Generate customer token
bd87035
@atwixfirster
Copy link
Contributor

Pull request: #677

@atwixfirster atwixfirster mentioned this issue Jun 12, 2019
Merged
@naydav
Copy link
Contributor Author

naydav commented Jun 12, 2019

#677

@naydav naydav closed this as completed Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atwixfirster atwixfirster

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.3
Development

No branches or pull requests
2 participants
@naydav @atwixfirster