Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Cloud: update key value list for web locations #8068

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Cloud: update key value list for web locations #8068

merged 5 commits into from
Oct 22, 2020

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Oct 15, 2020 •
edited
Loading

Purpose of this pull request

This pull request (PR) is to update the web key value list in the Cloud topic for .magento.app.yaml properties. This also addresses a request in GH issue #8021 .

Affected DevDocs pages

https://devdocs.magento.com/cloud/project/magento-app-properties.html#web

whatsnew
Updated the web property used in the magento.app.yaml properties topic in the Cloud guide.

@hguthrie hguthrie self-assigned this Oct 15, 2020
@hguthrie
Copy link
Contributor Author

Hi @NadiyaS could someone from Cloud team take a look at this list for the web properties for .magento.app.yaml?
It was out of date and was missing some key values that we include in our examples. I reordered the list so they are alphabetical. And I added a couple that were missing, but need confirmation and help defining defaults or purpose.

@hguthrie hguthrie requested a review from NadiyaS October 16, 2020 13:51
@hguthrie hguthrie marked this pull request as ready for review October 21, 2020 17:39
@hguthrie hguthrie requested a review from meker12 October 21, 2020 17:39
@hguthrie hguthrie added Technical Updates to the code or processes that alter the technical content of the doc 2.x labels Oct 21, 2020
@hguthrie
Copy link
Contributor Author

running tests

@hguthrie hguthrie merged commit 1ba3e40 into master Oct 22, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the hg-gh8021-weballow branch October 22, 2020 18:17
@hguthrie hguthrie added the Internal Dev Differentiates work between community and Magento staff label Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meker12 meker12 meker12 approved these changes

@NadiyaS NadiyaS NadiyaS approved these changes

Assignees

@hguthrie hguthrie

@meker12 meker12

@NadiyaS NadiyaS

Labels
2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hguthrie @meker12 @NadiyaS