-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GraphQL: Add uid for various products #7416
Conversation
…aphql-giftcard-idv2
…aphql-giftcard-idv2
…aphql-giftcard-idv2
I broke symlinks in this PR, making it appear as if all the content is new. My changes are limited to:
Note: I didn't previously have an example showing a customizable option, and so I didn't create one to show the |
Hi @keharper. I believe it's not a big deal since it's just an example. But the https://github.com/magento/devdocs/pull/7416/files#diff-445a68c46a7c2e44ad0317182ba7c305R156 |
@rogyar Is there anything I need to change with respect to the Also, I forgot to mention that I deliberately did not document the GiftCardCartItem data type in this PR. I need to create a new section in the left navigation of devdocs about interfaces and their implementations. I'll do that all at once in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I noticed you spell out SKU in certain attribute lists but not in others, such as BundleProduct object.
Hi @keharper. I would suggest randomizing "options": [
{
"id": 1,
"uid": "YnVuZGxlLzEvMS8x",
...
},
{
"id": 2,
"uid": "YnVuZGxlLzEuiBy7",
...
},
{
"id": 3,
"uid": "YnVuZGRlLzbuiBym",
...
}
] Something like that. Here's the link to the mentioned example. Sorry, I cannot use inline suggestions for this PR for some reason. |
@rogyar The Statis ball uids. Only the character before the 8 differs Yoga brick uid Straps uids. Again, only the character before the 8 differs Roller uid |
Hi @keharper. My bad. They look very similar. No suggestions from my end then. Everything looks good. Thank you. |
running tests |
Hi @keharper, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds the uid attribute to the GiftCardAmounts object, per https://github.com/magento/partners-magento2ee/pull/263
CE PR that added
uid
attributes to several product types:magento/magento2#28210
Affected DevDocs pages
Links to Magento source code