Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only active ports by default in port listings #127

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

arjunsalyan
Copy link
Member

I am trying to break #122 so that the bug can be fixed without being delayed due to the "Include deleted ports" filter.

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #127 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   73.84%   73.91%   +0.07%     
==========================================
  Files          46       46              
  Lines        1338     1342       +4     
==========================================
+ Hits          988      992       +4     
  Misses        350      350
Impacted Files Coverage Δ
app/ports/views.py 57.75% <100%> (ø) ⬆️
app/ports/models/port.py 88.66% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafaefc...bf9be84. Read the comment docs.

@mojca
Copy link
Member

mojca commented Oct 10, 2019

When we implement more general filters we could probably improve / generalize the code a bit, but it looks fine for now.

@mojca mojca merged commit cbf3672 into macports:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants