Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display deleted ports unless the user asks you to #110

Closed
pmetzger opened this issue Sep 5, 2019 · 8 comments
Closed

Don't display deleted ports unless the user asks you to #110

pmetzger opened this issue Sep 5, 2019 · 8 comments
Labels
enhancement New feature or request search engine

Comments

@pmetzger
Copy link
Member

pmetzger commented Sep 5, 2019

Most of the time, if I'm searching MacPorts I'm looking for information about ports that are currently in the tree. It is relatively rare that I want to see data on deleted ports. So, I'd like to ask that unless the user checks a box or otherwise indicates they want to see deleted ports as well, that the deleted ports not be shown.

@arjunsalyan
Copy link
Member

Thank you, I wrote a comment relating to this in #108 .

@mojca

@pmetzger
Copy link
Member Author

Hi, just curious if this can be acted on? I'm finding it much harder working with (for example) the ocaml part of the tree where I got rid of a lot of obsolete ports because I can't filter the deleted ones out...

@arjunsalyan
Copy link
Member

I am working on it, there was a bug that prevented the deleted ports from getting detected, it just got fixed yesterday.
I will add the functionality to filter out deleted ports by this weekend.

@pmetzger
Copy link
Member Author

Thank you so much, @arjunsalyan!

arjunsalyan added a commit to arjunsalyan/macports-gsoc-2020-webapp that referenced this issue Sep 28, 2019
@arjunsalyan
Copy link
Member

arjunsalyan commented Sep 28, 2019

I have deployed a test version (a checkbox below the search bar):
http://ec2-52-34-234-111.us-west-2.compute.amazonaws.com/

Could you please see if it works fine and satisfies the requirement?
You may need to clear website data or do a hard refresh before it works as expected!

@pmetzger
Copy link
Member Author

Seems good to me...

@mojca
Copy link
Member

mojca commented Jul 21, 2021

See also #283.

@mascguy
Copy link
Member

mascguy commented Feb 4, 2022

I definitely would prefer that deleted ports be hidden by default, with the current checkbox changed to "Show deleted ports." (Disabled by default.)

Indeed, checking the box to hide deleted ports is a necessity for me personally, as there are a boatload of openmpi-* and mpich-* subports that were removed last year.

Just curious, why was this closed? Is the intention to implement this as part of #283?

EDIT: Never Mind, inverting this is indeed covered by 283. Sorry folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request search engine
Projects
None yet
Development

No branches or pull requests

4 participants