fromDayBefore() returns rates from wrong 'before' days #17
Labels
Comments
maciej-sz
added a commit
that referenced
this issue
Aug 6, 2024
maciej-sz
added a commit
that referenced
this issue
Aug 6, 2024
maciej-sz
added a commit
that referenced
this issue
Feb 2, 2025
* #17 - fix getting rates for day before if there are gaps in table * #24 - updates preparing for 7.x support drop * #24 - ci updates; remove circleci * #24 - update test pipeline * #24 - update ref commit to run * #24 - added coverage * #24 - moved validation of composer.json before adjustments * #24 - removed validation of composer.json * #24 - workflow split based on php versions * #24 - moved caching before update * #24 - testing php version on pipeline * #24 - testing php version on pipeline * #24 - testing php version on pipeline * #24 - new adjust system for older php versions; coverage retrieval script * #24 - remove php 8.1 from GH workflow * #24 - test pipeline status send * #24 - test pipeline status send * #24 - test pipeline status send * #24 - test pipeline status send * #24 - test pipeline status send * #24 - split test and coverage workflows * #24 - split test and coverage workflows * #24 - updated php-version variable * #24 - updated php-version variable * #24 - moved the php-version variable to env * #24 - added delta coverage from main branch * #24 - downgrade PHP version to run coverage * #24 - ignore test result on main branch for coverage purposes * #24 - preserve get-coverage.php scripts * #24 - applied cs-fixer fixes * #24 - added cs-fixer workflow * #24 - added cs-fixer workflow * #24 - added PHPStan workflow * #24 - added Deptrac workflow * #24 - added cs-fix composer script * #24 - added deptrac, updated some array type annotations * #24 - fix after rebasing master * #24 - revert the change `new` to `create` as it would cause too much BC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$rate = $currencyAverages->fromDayBefore('2024-07-28')->fromTable('A')->getRate('EUR'); echo $rate->getEffectiveDate()->format('Y-m-d');fromDayBefore: 2024-07-28,
response effectiveDate: 2024-06-28,
expected: 2024-07-26
fromDayBefore: 2024-05-12,
response effectiveDate: 2024-04-30,
expected: 2024-05-10
and so on...
The text was updated successfully, but these errors were encountered: