Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides not being added correctly #41

Closed
RedClawx opened this issue Nov 16, 2023 · 2 comments
Closed

Overrides not being added correctly #41

RedClawx opened this issue Nov 16, 2023 · 2 comments

Comments

@RedClawx
Copy link

When adding an override the path is not getting recorded correctly into the preference file. I am following the instruction from https://github.com/macadmins/outset/wiki/ScriptOverrides. I am attempting to add two overrides. If the script is located in the "login-once" folder it gets added correctly. If the script is located in the "login-privileged-once" it does not get added correctly. The commands used are as follows:

sudo /usr/local/outset/outset --add-override /usr/local/outset/login-once/Remove_MS_Office_VL_User.sh
sudo /usr/local/outset/outset --add-override /usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh

When I look at the /Library/Preferences/io.macadmins.Outset.plist file the results are as follows:

<key>override_login_once</key>
<dict>
	<key>/usr/local/outset/login-once//usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh</key>
	<date>2023-11-16T19:25:46Z</date>
	<key>/usr/local/outset/login-once/Remove_MS_Office_VL_User.sh</key>
	<date>2023-11-16T19:26:01Z</date>
</dict>
@RedClawx
Copy link
Author

I did more testing. It also appears that even if I have an override in a script not located in login-once it won't run if the script has already been ran. For example, if the io.macadmins.Outset.plist file is:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>ignored_users</key>
	<array/>
	<key>network_timeout</key>
	<integer>180</integer>
	<key>override_login_once</key>
	<dict>
		<key>/usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh</key>
		<date>2023-11-16T19:25:46Z</date>
		<key>/usr/local/outset/login-once/Remove_MS_Office_VL_User.sh</key>
		<date>2023-11-16T19:26:01Z</date>
	</dict>
	<key>run_once-brettdecarion</key>
	<dict>
		<key>/usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh</key>
		<date>2023-11-16T19:09:22Z</date>
	</dict>
	<key>wait_for_network</key>
	<true/>
</dict>
</plist>

The script located in login-privileged-once will not run again even though it's in the override_login_once section.

bartreardon added a commit that referenced this issue Feb 29, 2024
@bartreardon bartreardon mentioned this issue Apr 9, 2024
@bartreardon
Copy link
Contributor

This was merged back in April but the issue was never closed. Will close now but if it's still an issue, please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants