今までの変更差分の適用 #74
Annotations
10 errors and 3 warnings
lint:
Gemfile#L209
[Correctable] Layout/LeadingCommentSpace: Missing space after #. (https://rubystyle.guide#hash-space)
|
lint:
app/lib/activitypub/activity/create.rb#L88
[Correctable] Layout/TrailingWhitespace: Trailing whitespace detected. (https://rubystyle.guide#no-trailing-whitespace)
|
lint:
app/lib/activitypub/activity/create.rb#L441
[Correctable] Style/RedundantFetchBlock: Use fetch('SPAM_CHECK_ENDPOINT', 'false') instead of fetch('SPAM_CHECK_ENDPOINT') { 'false' }. (https://github.com/JuanitoFatas/fast-ruby#hashfetch-with-argument-vs-hashfetch--block-code)
|
lint:
app/lib/activitypub/activity/create.rb#L442
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
lint:
app/lib/activitypub/activity/create.rb#L442
[Correctable] Style/NumericPredicate: Use @mentions.count.zero? instead of @mentions.count == 0. (https://rubystyle.guide#predicate-methods)
|
lint:
app/lib/activitypub/activity/create.rb#L445
[Correctable] Style/GuardClause: Use a guard clause (return true if (!@status.account.local? && @status.account.followers_count.zero? && @status.account.created_at > 1.day.ago && @mentions.count >= 2)) instead of wrapping the code inside a conditional expression. (https://rubystyle.guide#no-nested-conditionals)
|
lint:
app/lib/activitypub/activity/create.rb#L445
[Correctable] Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an if. (https://rubystyle.guide#no-parens-around-condition)
|
lint:
app/lib/activitypub/activity/create.rb#L446
[Correctable] Style/RedundantReturn: Redundant return detected. (https://rubystyle.guide#no-explicit-return)
|
lint:
app/lib/activitypub/activity/create.rb#L448
[Correctable] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
|
lint:
app/lib/activitypub/activity/create.rb#L449
Performance/MapMethodChain: Use map { |x| x.account.username } instead of map method chain.
|
lint:
app/services/statuses_search_service.rb#L8
Lint/MissingSuper: Call super to initialize state of the parent class.
|
lint:
lib/paperclip/storage/non_delete_filesystem.rb#L43
[Correctable] Lint/AssignmentInCondition: Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition. (https://rubystyle.guide#safe-assignment-in-condition)
|
lint:
lib/paperclip/storage/non_delete_filesystem.rb#L71
[Correctable] Lint/UselessAssignment: Useless assignment to variable - e. (https://rubystyle.guide#underscore-unused-vars)
|