[CHILD OF #369] Buttons to skip to next compound/hit with same settings (both LHS and RHS) #384

phraenquex · 2020-06-19T13:10:08Z

When investigating compounds (RHS) or hits (LHS), it will be extremely useful to be able to jump to the next (or previous) one with a single button-click, with all view settings applied.

Clicking the down button should turn off the one above while turning on the one below, transferring everything from the compound above to the one below:

remember the FULL display settings of the compound/hit above the arrow.

For "F", if any hits are displayed, consider that as all hits displayed; and if no hits are displayed, then keep that setting.
(Ideally) if any display settings were customised for either protein, ligand or contacts, then remember those too.
(pragatically) if the previous point is too difficult, then don't bother.

turn off all displayed elements (except protein ribbon)
apply the settings of (1) above to the compound below the arrow.

But do not reset the view.
Ditto for the up arrow, but just the other way round.

phraenquex · 2020-06-23T12:25:55Z

Nice arrows! And great to have this, thanks! But there's a remaining bug, so moving back to in progress.

Remaining bug: turning on/off of the inspiration hits isn't working: first bullet of point 1 in the spec.

In the snapshot below: I had all inspirations of one compound turned on (PAU-WEI-b9b69149-8), then I pressed the button circled red; it proceeded as required, EXCEPT not all inspirations got turned on (they should have).

The other way round is also wrong (snapshot below): with not all fragments turned on, I clicked the down button (circled red): it proceeded correctly, except now it should have turned OFF all inspirations for that next compound (it didn't turn off anything).

phraenquex · 2020-06-23T12:27:09Z

Also: if the Inspirations modal is open, it should also move when the arrow is clicked (up or down).

phraenquex · 2020-06-23T13:15:41Z

Left it in "In progress" - too much of the ticket was not implemented. Please either do properly, or else explain why not.

reskyner · 2020-06-23T17:13:54Z

I don't like the up/down buttons being next to every molecule. The behaviour I'd expect from those buttons is something like that molecule moving up/down the list. I think the behaviour is nice, but I'd prefer it if there was a single set of two buttons (up and down or left and right) either above or below the navigator. Like this:

reskyner · 2020-06-23T17:15:40Z

Or this:

phraenquex · 2020-06-24T12:43:21Z

More fixes:

the arrows should show up ONLY for highlighted (i.e. displayed) compounds
if an arrow is clicked, ALL other compounds should be turned off, not only the compound that had the arrow
the settings to be transferred onto the new compound should be taken from the compound whose arrow was clicked; the settings of all other compounds should be ignored.

phraenquex · 2020-06-24T13:02:02Z

Commenting on Rachael's request: I do NOT want the buttons down below, they should be displayed on the compound itself, because that's where my eye is when I use them.

# Conflicts: # js/components/datasets/customDatasetList.js # js/components/datasets/datasetMoleculeView.js # js/components/datasets/redux/dispatchActions.js

tibor-postek-m2ms · 2020-06-27T16:02:27Z

solved in #369

tibor-postek-m2ms · 2020-06-27T16:41:36Z

merged in rhs-filter branch

…as implemented. #370, #384

reskyner · 2020-07-08T16:43:47Z

The bug with the colour on the background image still remains: #396, but is listed under the next milestone. Will let @phraenquex decide wether this is fine to leave as it is for now.

phraenquex · 2020-07-09T05:41:30Z

Distressingly, the inspiration fragments are STILL not being turned off and on (as I specced 23 June). But we can't wait - push to production.

I'll make a new ticket for the next milestone.

* #371 add total count of molecules into footer of molecule lists * #371 show warning modal window after click on load full list, that has more than 100 molecules * #360 add auto center button into molecule lists * #360 fix centering ligands from right side, fix layout of molecule buttons * #360 auto focus only first molecule from site 1 in target mode * #360 uncomment feature to able to select first protein * #360 change style of centre on molecule button * #371 change description of alert modal * #384 add layout of up/down arrows * #384 move same settings to next/previous compound in LHS * #384 move same settings to next/previous compound in RHS * #369 not successful load text values of scores * #369 show score values in RHS, but cannot open filter * #369 parse numbers, text and booleans in RHS * #369 load scores and molecules in one request * #369 fix bug with opening filter * #384 new behaviour of buttons to skip * #390 add dropdown to dataset tab menu header * #371 add total count of molecules into footer of molecule lists * #371 show warning modal window after click on load full list, that has more than 100 molecules * #360 add auto center button into molecule lists * #360 fix centering ligands from right side, fix layout of molecule buttons * #360 auto focus only first molecule from site 1 in target mode * #360 uncomment feature to able to select first protein * #360 change style of centre on molecule button * #367 load only first ligand and protein of first molecule after first loading of target * #367 load only first ligand and protein of first molecule after first loading of target * #369 fix showing score details in filter of RHS * #369 loading all datasets data in Preview component * #369 show boolean in filter * - fixed #391, #367 - work in progress #370 * - fixed right hand side sorting and three way logic was bool values was implemented. #370, #384 * - #401 - fixed not changing molecules when changing the order - #400 - now in the LHS the rounded values are used for sorting * -fixed wrong initial order of compounds on the right hand side * - #402 new approach for downloading the data * data sets only for compatible targets. updated readme with instructions when loader and/or backend is changed * another try to filter out custom datasets * updated launch.json Co-authored-by: Tibor Postek <tibor.postek@m2ms.sk>

…revious arrows (bug of #384)

* Update build-main.yaml got rid of scheduled rebuild because it's messing up data * updated react16 to react 18.2, replaced hot-loaders modules by react-refresh, removed react-undo module * added proper values for Typography variant * renamed obsolete create theme function * #1063 added header and search * #1063 fixed body table, page count and search * #1063 fixed minor bugs and set clear filter * Squashed commit of the following: commit 10925d2 Author: RobertMatuska <robert.matuska@m2ms.sk> Date: Thu Sep 28 10:27:36 2023 +0200 #1114 edited text and style * #1161 setted search and filter for old target list * #1161 fixed discourse icon padding * #1161 fixed filtered list sort * #1161 fixed target access sort and filter * #1161 fixed change page * #1145 preserve state of molecule rendering, save also actions of representation changes to snapshot * do not wrap display controls buttons * #1167 resize target list colmuns * #1161 fixed sorting * #1161 fixed sorting * #1161 edit sort functionality for filter table * #1161 fixed search, filter, sort by target access * #1161 created init date column * #1161 # filtering and sorting init date * #1161 fixed clear and sort init date * #1161 fixed target sorting * Squashed commit of the following: commit d489526 Merge: 1c45038 411921f Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Mon Oct 16 08:24:05 2023 +0200 Merge branch '#1173' of https://github.com/m2ms/fragalysis-frontend into #1173 commit 1c45038 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Fri Oct 13 11:03:49 2023 +0200 - implemented #1173 also with save/restore and undo/redo functionality commit 411921f Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Fri Oct 13 11:03:49 2023 +0200 - implemented #1173 also with save/restore and undo/redo functionality * merge * Squashed commit of the following: commit 7883c15 Merge: 5e2b937 19b9f24 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Mon Oct 16 11:19:36 2023 +0200 Merge branch '#1172' of https://github.com/m2ms/fragalysis-frontend into #1172 commit 5e2b937 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Mon Oct 16 11:16:15 2023 +0200 - added compound_set to csv export - #1172 commit 19b9f24 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Mon Oct 16 11:16:15 2023 +0200 - added compound_set to csv export - #1172 commit 75ac125 Merge: f50666c 574c7b5 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Mon Oct 16 08:26:08 2023 +0200 Merge branch '#1172' of https://github.com/m2ms/fragalysis-frontend into #1172 commit f50666c Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Fri Oct 13 13:45:34 2023 +0200 - implemented #1172 commit 574c7b5 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Fri Oct 13 13:45:34 2023 +0200 - implemented #1172 * #1167 fixed issues * #1167 reworked resizer * #1161 fixed merge bugs * #1161 removed console * updated react16 to react 18.2, replaced hot-loaders modules by react-refresh, removed react-undo module * added proper values for Typography variant * renamed obsolete create theme function * changed deprecated justify= to justifyContent= * fixed some landing page errors, mostly missing key and using useState outside of useEffect in functional component * #1061 loading and toast functionality move from header context into LoadingContext and ToastContext, added loading indicator for tags and hits panes + hit/molecule control buttons * #1171 return representations when loading protein without quality to show it in display control * do not set logged in toast message if user is not logged in * fixed Tooltip error messages about its disabled child, fixed invalid variant type and removed xs from Grid container (it is Grid item property) * fixed null value for open property * fixed "ButtonGroup component doesn't accept a Fragment as a child. Consider providing an array instead" * fixed "<div> cannot appear as a descendant of <p>" error by adding "component={'div'}" property to complex Typography component * removed invalid way of setting color for tag, it does not work - only throws error and with proper setting it is same as background color.. * fixed missing key error * fixed invalid references erros * fixed unknown properties error and missing key * - #1139 - updated docker-compose file to be ready for new backend version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - changed configuration * - #1139 - updated docker-compose file to be ready for new backend version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - fixed search bar placeholder for hits * - #1139 - updated docker-compose file to be ready for new backend version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - #1139 - fixed snapshot creation and restoration * #1167 target and project list resizer * #1167 fixed project list width * #1161 changed width * - #1183 - dynamic handling of tag categories * - fixed #1186 * - job file transfer backend * - checkpoint * - new CI/CD * Update build-main.yaml got rid of scheduled rebuild because it's messing up data * updated react16 to react 18.2, replaced hot-loaders modules by react-refresh, removed react-undo module * added proper values for Typography variant * renamed obsolete create theme function * changed deprecated justify= to justifyContent= * fixed some landing page errors, mostly missing key and using useState outside of useEffect in functional component * rebase * #1171 return representations when loading protein without quality to show it in display control * do not set logged in toast message if user is not logged in * fixed Tooltip error messages about its disabled child, fixed invalid variant type and removed xs from Grid container (it is Grid item property) * fixed null value for open property * fixed "ButtonGroup component doesn't accept a Fragment as a child. Consider providing an array instead" * fixed "<div> cannot appear as a descendant of <p>" error by adding "component={'div'}" property to complex Typography component * removed invalid way of setting color for tag, it does not work - only throws error and with proper setting it is same as background color.. * fixed missing key error * fixed invalid references erros * fixed unknown properties error and missing key * - #1139 - updated docker-compose file to be ready for new backend version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - changed configuration * - #1139 - updated docker-compose file to be ready for new backend version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - fixed search bar placeholder for hits * - #1139 - updated docker-compose file to be ready for new backend version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - initial implementation of #1139 - tags and molecules * - #1139 - tags, molecules updated to use new api - not final version * - #1139 - fixed snapshot creation and restoration * - #1183 - dynamic handling of tag categories * - job file transfer backend * - checkpoint * - new CI/CD * - fixed build errors --------- Co-authored-by: matej <matej.vavrek@m2ms.sk> Co-authored-by: RobertMatuska <robert.matuska@m2ms.sk>

phraenquex added idea New idea submitted by user from feedback form urgent fix Ver 0.8.0 labels Jun 19, 2020

tibor-postek-m2ms added a commit that referenced this issue Jun 22, 2020

#384 add layout of up/down arrows

94ca9af

tibor-postek-m2ms added a commit that referenced this issue Jun 22, 2020

#384 move same settings to next/previous compound in LHS

03e3264

tibor-postek-m2ms added a commit that referenced this issue Jun 22, 2020

#384 move same settings to next/previous compound in RHS

891f713

tibor-postek-m2ms added a commit that referenced this issue Jun 24, 2020

#384 add layout of up/down arrows

9fdebdc

tibor-postek-m2ms added a commit that referenced this issue Jun 24, 2020

#384 move same settings to next/previous compound in LHS

f64a369

tibor-postek-m2ms added a commit that referenced this issue Jun 24, 2020

#384 move same settings to next/previous compound in RHS

5637fd8

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 new behaviour of buttons to skip

5b0d46f

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 new behaviour of buttons to skip

ec0f607

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 add layout of up/down arrows

2cbd1e6

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 move same settings to next/previous compound in LHS

b96dff9

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 move same settings to next/previous compound in RHS

efeff57

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 new behaviour of buttons to skip

cc48037

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 add layout of up/down arrows

174dda6

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 move same settings to next/previous compound in LHS

4952eac

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 move same settings to next/previous compound in RHS

435bcbc

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

#384 new behaviour of buttons to skip

cf7df51

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

Merge branch '#384' into #369

ae4273c

# Conflicts: # js/components/datasets/customDatasetList.js # js/components/datasets/datasetMoleculeView.js # js/components/datasets/redux/dispatchActions.js

tibor-postek-m2ms added a commit that referenced this issue Jun 27, 2020

Merge branch '#384' into #369

5296440

# Conflicts: # js/components/datasets/customDatasetList.js # js/components/datasets/datasetMoleculeView.js # js/components/datasets/redux/dispatchActions.js

tibor-postek-m2ms changed the title ~~Buttons to skip to next compound/hit with same settings (both LHS and RHS)~~ [CHILD OF #369] Buttons to skip to next compound/hit with same settings (both LHS and RHS) Jun 27, 2020

boriskovar-m2ms added a commit that referenced this issue Jul 3, 2020

- fixed right hand side sorting and three way logic was bool values w…

9ef2b0f

…as implemented. #370, #384

phraenquex mentioned this issue Jul 9, 2020

Properly turn on/off inspiration fragments when using the next/previous arrows (bug of #384) #407

Open

ak-m2ms pushed a commit that referenced this issue Oct 14, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

6d4b9a4

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 14, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

014b431

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 16, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

3a429c4

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 16, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

90defc1

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 19, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

0d62099

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 20, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

cce0498

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 20, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

f68cd67

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 20, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

174a35e

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 21, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

6cbbeb7

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 22, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

9dfd6b7

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 23, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

7d7f6bf

…revious arrows (bug of #384)

ak-m2ms pushed a commit that referenced this issue Oct 26, 2020

#407 Properly turn on/off inspiration fragments when using the next/p…

8ee0f83

…revious arrows (bug of #384)

mwinokan added this to Fragalysis May 29, 2024

mwinokan moved this to In production (Done) in Fragalysis May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHILD OF #369] Buttons to skip to next compound/hit with same settings (both LHS and RHS) #384

[CHILD OF #369] Buttons to skip to next compound/hit with same settings (both LHS and RHS) #384

phraenquex commented Jun 19, 2020

phraenquex commented Jun 23, 2020

phraenquex commented Jun 23, 2020

phraenquex commented Jun 23, 2020

reskyner commented Jun 23, 2020

reskyner commented Jun 23, 2020

phraenquex commented Jun 24, 2020

phraenquex commented Jun 24, 2020

tibor-postek-m2ms commented Jun 27, 2020

tibor-postek-m2ms commented Jun 27, 2020

reskyner commented Jul 8, 2020

phraenquex commented Jul 9, 2020

[CHILD OF #369] Buttons to skip to next compound/hit with same settings (both LHS and RHS) #384

[CHILD OF #369] Buttons to skip to next compound/hit with same settings (both LHS and RHS) #384

Comments

phraenquex commented Jun 19, 2020

phraenquex commented Jun 23, 2020

phraenquex commented Jun 23, 2020

phraenquex commented Jun 23, 2020

reskyner commented Jun 23, 2020

reskyner commented Jun 23, 2020

phraenquex commented Jun 24, 2020

phraenquex commented Jun 24, 2020

tibor-postek-m2ms commented Jun 27, 2020

tibor-postek-m2ms commented Jun 27, 2020

reskyner commented Jul 8, 2020

phraenquex commented Jul 9, 2020