-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output experimental data paths for use in F/E #1497
Comments
What is needed is the frontend to know the original location of the PDB file - the thing that's in soakDB. @tdudgeon needs to add to XCA/yamls |
Collator now adds
Commit: xchem/xchem-align@c6e6ded Example data: https://im-xchem-data.s3.amazonaws.com/lb32627-66_18-SEP.tgz |
@matej-vavrek source paths are available in |
@matej-vavrek please add a clipboard icon to the F/E observation expanded table under a heading "Path" |
Latest alignment from A71EV2A on staging includes the absolute paths in the /api/experiments endpoint |
@phraenquex, @mwinokan, I have updated my stack. Currently, it uses |
Thanks @matej-vavrek the correct field is |
@phraenquex, @mwinokan, changed field and also added a note into tooltip when it is empty, is it ok? |
@matej-vavrek please push this to staging so we can test with new data |
@mwinokan @matej-vavrek should I be expecting to see this in staging for the A71EV2A you uploaded yesterday? Because I don't.... https://fragalysis.xchem.diamond.ac.uk/viewer/react/projects/100/71 |
@phraenquex it was briefly there but staging is out of date (see slack thread) they should reappear on the next staging rebuild |
@mwinokan is this the path we'd expect - specifically the CIF file? |
@kaliif the path that should be served to the frontend is the path to the PDB file. Fix that, and then we can close the ticket. |
@matej-vavrek says that the f/e is using querying:
@kaliif it seems that you are currently serving the |
F/E is now correctly serving the refined PDB, e.g. for
|
* Squashed commit of the following: commit e613216 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag * #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height * #1508 adjusted column order and width calculation * #1501 added upload links to menu * #1520 show tag alias instead of upload_name on hit navigator CanonSites & ConformerSites box tooltip * #1519 keep tag in edit window after save * #1497 added Path column for extended view of observations --------- Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
To shorten the feedback loop between alignment, upload, and reviewing of data in case there are faulty observations, @phraenquex suggests that we need some UI to be able to see the paths to the original experimental data for each observation.
This will require collator/aligner changes in XCA @tdudgeon
F/E UI specs still to follow @matej-vavrek
The text was updated successfully, but these errors were encountered: