Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulation support for RGB and stereo cameras #78

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

Kotochleb
Copy link
Contributor

This PR adds support for simulated cameras in Gazebo. Names of the topic are based on the launch files in the repo. This is why if possible please check if they are correct.

</plugin>
</gazebo>

<link name="rae_stereo_front_frame">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In real robot, stereo images' frames are set based on which sensor the stereo is aligned to (so it could be rgb, right,left, etc.), for now it is usually right` frame

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed now the camera names. Now there are only right and left_back cameras as on real robot

world_file = LaunchConfiguration('sdf_file').perform(context)
print(f'world_file: {world_file}')

ns_srt = namespace.perform(context)
ns_srt = f'/{ns_srt}' if ns_srt else ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd either put that in a function or add a small comment explaining the behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my mistake. I accidentally committed this bit. It is removed now

<topic>/rae/right/image_raw</topic>
<ignition_frame_id>rae_rgb_camera_optical_frame</ignition_frame_id>
<camera>
<horizontal_fov>${105.0/180.0*pi}</horizontal_fov>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensor information can be found here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully fixed

@Kotochleb Kotochleb requested a review from Serafadam March 28, 2024 15:51
@Kotochleb
Copy link
Contributor Author

I left RGB camera macro unused as this camera is not launched by rae_bringup bringup.launch.py right now. The rest should match the real robot

@Serafadam Serafadam merged commit 52b73b2 into luxonis:humble Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants