-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulation support for RGB and stereo cameras #78
Conversation
rae_description/urdf/rae.urdf.xacro
Outdated
</plugin> | ||
</gazebo> | ||
|
||
<link name="rae_stereo_front_frame"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In real robot, stereo
images' frames are set based on which sensor the stereo is aligned to (so it could be rgb, right,left, etc.), for now it is usually
right` frame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed now the camera names. Now there are only right
and left_back
cameras as on real robot
rae_gazebo/launch/gazebo.launch.py
Outdated
world_file = LaunchConfiguration('sdf_file').perform(context) | ||
print(f'world_file: {world_file}') | ||
|
||
ns_srt = namespace.perform(context) | ||
ns_srt = f'/{ns_srt}' if ns_srt else '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd either put that in a function or add a small comment explaining the behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my mistake. I accidentally committed this bit. It is removed now
rae_description/urdf/rae.urdf.xacro
Outdated
<topic>/rae/right/image_raw</topic> | ||
<ignition_frame_id>rae_rgb_camera_optical_frame</ignition_frame_id> | ||
<camera> | ||
<horizontal_fov>${105.0/180.0*pi}</horizontal_fov> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensor information can be found here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully fixed
I left |
This PR adds support for simulated cameras in Gazebo. Names of the topic are based on the launch files in the repo. This is why if possible please check if they are correct.