-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Code #68
Refactor Code #68
Conversation
Test Results143 tests 143 ✅ 1s ⏱️ Results for commit 13d7d4a. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, did you delete AgeGender msg from messages
? Did you test that all parsers that are affected work and that examples work?
Not sure if we want to have to parsers in the same file or not (Classification and MultiClassification parsers)? CC @klemen1999 @jkbmrz
Thanks for noticing, yes I forgot to remove AgeGender message. All message creators are working, I also tested AgeGender, PaddleOCR, VehicleAttributes parsers. In the example none of these parsers are used so there should be no error. |
AgeGender model is used in examples. Can you adjust the code so it works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR Refactors parts of the code. Some examples include:
classification
messages into a single file,create_age_gender_message
to return CompositeMessage instead of AgeGenderMessage.