Fix creators. #42
Merged
Fix creators. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkeroo
requested review from
jkbmrz and
aljazkonec1
and removed request for
jkbmrz
Test Results117 tests 117 ✅ 1s ⏱️ Results for commit f21a70e. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
klemen1999
approved these changes
Sep 2, 2024
jkbmrz
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes depth and keypoints creators because they did not support all parsers. Keypoints should also support scores = None because some models (Face-mesh) doesnt have scores for the keypoints. Depth creator wasnt accepting all shapes. DepthAnything models outputs 2-dimensional result.
Tests are also modified.
Additionally, examples have some fixes. parser setup is moved to separate file because we need to star-import all parsers. precommit - ruff had problems with that in model.py file becuase then
typeslikeClassificationclass were not explicitly imported.