Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples added. #35

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Examples added. #35

merged 7 commits into from
Aug 30, 2024

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Aug 30, 2024

This PR adds general example script main.py. It requires one argument -s or --slug representing model slug. The script then automatically sets the whole pipeline - creates camera with correct output size, network node, parser node with right settings, and visualization.

The script catches errors if the model is not available from HubAI.

All public models work except:

  1. XFeat - needs advanced visualization - like msgs syncing, two cameras etc. Will be added. If the user requests XFeat NotImplementedError is thrown
  2. DepthAnything v2 MDE versions - because metric depth type is not yet implemented. CC @jkbmrz to implement it.
  3. MP palm detection 128x128 IR version - because it was added later by apps-team. Need to adjust the parser.

The examples work for RVC2 devices.

@kkeroo kkeroo requested a review from klemen1999 August 30, 2024 11:41
@kkeroo kkeroo self-assigned this Aug 30, 2024
@kkeroo
Copy link
Collaborator Author

kkeroo commented Aug 30, 2024

@klemen1999 I also plan to add one readme in the examples to explain the usage.

@kkeroo kkeroo force-pushed the examples/general-example branch from 37473f8 to 1c353dd Compare August 30, 2024 13:12
Copy link

github-actions bot commented Aug 30, 2024

Test Results

117 tests   117 ✅  1s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 06d8abb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 30, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1566 706 45% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 06d8abb by action🐍

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkeroo kkeroo added the examples Changes affecting examples. label Aug 30, 2024
@kkeroo kkeroo merged commit e336c19 into main Aug 30, 2024
10 checks passed
@kkeroo kkeroo deleted the examples/general-example branch August 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Changes affecting examples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants