Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checking for img detection messages #3

Merged
merged 5 commits into from
May 30, 2024

Conversation

jkbmrz
Copy link
Collaborator

@jkbmrz jkbmrz commented May 28, 2024

Adding type checking for keypoints and detections attributes for ImgDetectionWithKeypoints and ImgDetectionsWithKeypoints messages using Python descriptors: keypoints must be an empty list or a list of tuples of two floats or integers; detections must be ImgDetectionWithKeypoints object.

@jkbmrz jkbmrz requested review from kkeroo and tersekmatija May 28, 2024 13:12
Copy link

@tersekmatija tersekmatija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but not sure if we actually need descriptor classes given we are not reusing them anywhere else?

Should we just handle validation in setter/getter methods?

@jkbmrz jkbmrz merged commit 0e60ed6 into main May 30, 2024
@jkbmrz jkbmrz deleted the feature/enforce_custom_msg_type_checking branch May 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants