Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser's parameters renaming. #26

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Parser's parameters renaming. #26

merged 4 commits into from
Aug 22, 2024

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Aug 21, 2024

This PR renames parameters in some parsers.

  1. Keypoints parser:
  • num_keypoints -> n_keypoints
  1. MP Palm detection, SCRFD, YuNet parsers:
  • score_threshold -> conf_threshold
  • nms_threshold -> iou_threshold
  • top_k -> max_det

Reason?
This is because some heads in NN archive have some required parameters that need to be set when creating NN Archive. For example, detection head has conf_threshold, iou_threshold, max_det. In the future DAI will be able to automatically map the parameters from archive to parser - that's why naming must be consistent.

@kkeroo kkeroo requested a review from klemen1999 August 21, 2024 13:51
@kkeroo kkeroo self-assigned this Aug 21, 2024
@kkeroo kkeroo merged commit 9a49670 into main Aug 22, 2024
1 check passed
@kkeroo kkeroo deleted the style/parameter_renaming branch August 22, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants