Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Improved logging in E2E. #159

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Tests: Improved logging in E2E. #159

merged 1 commit into from
Jan 10, 2025

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Jan 10, 2025

We also log the platform for which the model doesnt exists in the HubAI and log short trace-back if the test fail - this way we will see what caused the failing test. If its implementation error or connection error.

@github-actions github-actions bot added the tests Changes affecting tests label Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.15%. Comparing base (b93f10f) to head (1a81863).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   36.15%   36.15%           
=======================================
  Files          70       70           
  Lines        3986     3986           
=======================================
  Hits         1441     1441           
  Misses       2545     2545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkeroo kkeroo merged commit 7821118 into main Jan 10, 2025
10 checks passed
@kkeroo kkeroo deleted the tests/better-logging branch January 10, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Changes affecting tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants