Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: Small updates & triggering in every PR. #146

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Dec 5, 2024

This PR adds the ability to run integration tests on all connected platforms (RVC2, RVC4). If there are multiple RVC2 devices connected it will only select one.

Additionally, there was a bug in ImageOutputParser because we were setting the attribute transformation of the dai.ImgFrame which doesn't have this attribute - fixing it with the method setTransformations(). Hopefully, this bugs will be catched now:)

Lastly, we updated the CI workflows for E2E and integration tests with the option to specify which depthai version we want - the specified version will then be installed in the testbed server before the tests run. CI jobs will also wait until testbed is free and wont fail the job if testbed is reserved.

Integration tests are included in the CI for every PR. They are triggered only if the affected files are from /depthai-nodes or /tests/integration-tests folder.

Successful CI run for integration tests is HERE. It took 10 minutes.

@github-actions github-actions bot added the parsers Changes affecting ml.parsers label Dec 5, 2024
@kkeroo kkeroo added the tests Changes affecting tests label Dec 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.30%. Comparing base (37a2d92) to head (2fa4954).
Report is 17 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
depthai_nodes/ml/parsers/image_output.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   33.40%   33.30%   -0.10%     
==========================================
  Files          68       69       +1     
  Lines        3739     3837      +98     
==========================================
+ Hits         1249     1278      +29     
- Misses       2490     2559      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkeroo kkeroo changed the title Integration tests: Test on all connected platforms. Integration tests: Small updates & triggering in every PR. Dec 5, 2024
Copy link
Collaborator

@jkbmrz jkbmrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kkeroo kkeroo merged commit eb29bc7 into main Dec 10, 2024
11 checks passed
@kkeroo kkeroo deleted the tests/both-devices branch December 10, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsers Changes affecting ml.parsers tests Changes affecting tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants