[FIX] dai.ImgTransformations is None for RVC2 device #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljazkonec1
requested review from
tersekmatija,
jkbmrz,
kkeroo and
klemen1999
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 33.40% 33.31% -0.09%
==========================================
Files 68 69 +1
Lines 3739 3836 +97
==========================================
+ Hits 1249 1278 +29
- Misses 2490 2558 +68 ☔ View full report in Codecov by Sentry. |
|
I suggest that we dont merge features to main if they dont work with alpha releases because they can break the code and parsers dont work. Can we keep features in separate branches till alphas support them? Thoughts @aljazkonec1 @jkbmrz @klemen1999 ? |
kkeroo
approved these changes
Dec 3, 2024
|
Agreed, it was done on alpha6, just that I did not tryout RVC2 after the fact. |
klemen1999
approved these changes
Dec 3, 2024
jkbmrz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hotfix for using RVC2 device with depthai alpha6. The issue is that the dai.NNdata has self.transformation set to
None. This is a know issue in depthai and will be fixed in comming updates.The PR was tested on both RVC2 and RVC4 on the following models:
lane detection, depth anything, face landmarks, yolov8 instance seg, selfie seg, scfrd face detection, yolo v6, text detection