-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dai.ImgTransformations to messages and improvements to Text detection parser #142
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 33.40% 33.38% -0.02%
==========================================
Files 68 69 +1
Lines 3739 3828 +89
==========================================
+ Hits 1249 1278 +29
- Misses 2490 2550 +60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small remark but LGTM otherwise!
|
||
@property | ||
def transformation(self) -> dai.ImgTransformation: | ||
"""Returns the Image Transformation object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the transformation property and setter are the same for every message, we could also make a message parent class that would define them once instead of copy-pasting them to all messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I also thought about it. I asked depthai team and when this will get ported, all messages will inherit from dai.Buffer
and will have similar structure as dai.ImgDetections
currently has. Thats why I left it as is.
This PR adds the following:
dai.ImgTransformations
attribute to all depthai-nodes messages. This is necessary as the information inside dai.ImgTransofrmations is needed in later nodes for dai.ImgManip, and for visualization purposes as width, height and other values are stored in this attribute.