E2E Tests: ImageManip node and better checks. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkeroo
requested review from
tersekmatija,
jkbmrz and
klemen1999
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 33.40% 33.04% -0.36%
==========================================
Files 68 69 +1
Lines 3739 3746 +7
==========================================
- Hits 1249 1238 -11
- Misses 2490 2508 +18 ☔ View full report in Codecov by Sentry. |
klemen1999
approved these changes
Nov 26, 2024
|
@klemen1999 I am re-requesting your review since I updated the PR with the addition of |
kkeroo
changed the title
klemen1999
reviewed
Nov 26, 2024
| dai.ImgFrame.Type.BGR888i | ||
| if device.getPlatform().name == "RVC4" | ||
| else dai.ImgFrame.Type.BGR888p | ||
| ) |
There was a problem hiding this comment.
Can we set the type based on ˙dai_type˙ field in the NNArchive if present otherwise use this as default?
There was a problem hiding this comment.
Will be addressed in the future because dai has not yet implemented it.
jkbmrz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks added in E2E tests:
Every catch has a
print(e)so we know whats wrong when running it withmanual.pyThis PR also adds
ImageManipV2node to the pipeline if the model input size is not divisible by 2 (e.g. 513x513 in deeplab) or the input size is too small. We request 2 or 4 times bigger input size from the camera and then resize it down to model's input size withImageManipV2node.This feature now runs more models in E2E testing.