-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force NCHW tensor order. #135
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 33.40% 32.96% -0.45%
==========================================
Files 68 68
Lines 3739 3695 -44
==========================================
- Hits 1249 1218 -31
+ Misses 2490 2477 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but why are we not adding this feature to all parsers?
Other parsers dont explicitly check for the tensor order - it doesnt matter. E.g.:
and similar for other not-affected parsers. I think forcing |
This PR forces NCHW tensor output when calling
getTensor(...)
method instead of manually checking the shapes and transposing them inside parsers.Affected Parsers:
One yolo util function (
reshape_seg_outputs
) is removed - not needed anymore.Additionally,
ImgDetectionExtended
'smasks
parameter now expects int16 and not int8 (introduced in some previous PR) + detection creator function convertsmasks
to int16 instead of int8.