-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust ParsingNeuralNetwork to build model directly from the model slug #134
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 33.40% 32.84% -0.56%
==========================================
Files 68 68
Lines 3739 3717 -22
==========================================
- Hits 1249 1221 -28
- Misses 2490 2496 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment about keeping up with depthai definitions
…e or ModelDescription
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding an update to
ParsingNeuralNetwork
build()
method to match the recent changes in DAI (v3alpha6) that allow models to be built directly from slug:pipeline.create(ParsingNeuralNetwork).build(<CameraNode>, <dai.NNModelDescription OR dai.NNArchive>)
pipeline.create(ParsingNeuralNetwork).build(<CameraNode>, <Slug>)
Additionally, examples script was adjusted to reflect the new changes. Moreover,
slug
variables were renamed tomodels
(new naming convention)