Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust ParsingNeuralNetwork to build model directly from the model slug #134

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

jkbmrz
Copy link
Collaborator

@jkbmrz jkbmrz commented Nov 14, 2024

Adding an update to ParsingNeuralNetwork build() method to match the recent changes in DAI (v3alpha6) that allow models to be built directly from slug:

  • Previous functionality: pipeline.create(ParsingNeuralNetwork).build(<CameraNode>, <dai.NNModelDescription OR dai.NNArchive>)
  • The updated functionality: pipeline.create(ParsingNeuralNetwork).build(<CameraNode>, <Slug>)

Additionally, examples script was adjusted to reflect the new changes. Moreover, slug variables were renamed to models (new naming convention)

@jkbmrz jkbmrz changed the title feat: adjust ParsingNeuralNetwork to DAI v3 alpha6 feat: adjust ParsingNeuralNetwork to allow building directly from slug Nov 14, 2024
@jkbmrz jkbmrz changed the title feat: adjust ParsingNeuralNetwork to allow building directly from slug feat: adjust ParsingNeuralNetwork to build model directly from slug Nov 14, 2024
@jkbmrz jkbmrz changed the title feat: adjust ParsingNeuralNetwork to build model directly from slug feat: adjust ParsingNeuralNetwork to build model directly from the model slug Nov 14, 2024
@github-actions github-actions bot added the fix Fixing a bug label Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 32.84%. Comparing base (37a2d92) to head (c9bee4f).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
depthai_nodes/parsing_neural_network.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   33.40%   32.84%   -0.56%     
==========================================
  Files          68       68              
  Lines        3739     3717      -22     
==========================================
- Hits         1249     1221      -28     
- Misses       2490     2496       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the examples Changes affecting examples. label Nov 15, 2024
@jkbmrz jkbmrz requested a review from aljazkonec1 November 15, 2024 10:00
Copy link
Contributor

@aljazkonec1 aljazkonec1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment about keeping up with depthai definitions

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkbmrz jkbmrz merged commit 0ccc611 into main Nov 21, 2024
10 checks passed
@jkbmrz jkbmrz deleted the fix/parsing_neural_network branch November 21, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Changes affecting examples. fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants