-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: input size setting #126
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results125 tests 125 ✅ 1s ⏱️ Results for commit 1ed14ba. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this method could work but I wonder if there isn't a nicer way to infer input size based on the shape of the output and maybe some known stride information or something similar? We did it with YOLO but might not be applicable for all models so if this is not the case here then you can disregard this comment.
If we go ahead with using input_size
let's make sure we update this in the whole package accordingly.
I found no way of determining input size for
Let's wait for others to see what's their position on it and I can then proceed with changing it! |
…e from parser arguments
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage ? 33.27%
=======================================
Files ? 68
Lines ? 3754
Branches ? 0
=======================================
Hits ? 1249
Misses ? 2505
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Adding a fix to the parsers that require model input size and cannot deduce it from the model outputs (
YuNetParser
andLaneDetectionParser
) by extending thebuild()
method to look for the theinput_shape
within thehead_config
. Additionally,ParserGenerator
is updated to set theinput_shape
argument aromatically based on the relevantNN Archive
.Some additional changes:
input_size
was removed for theLaneDetectionParser
,input_shape
variable/parameter names were changed toinput_size
because it better fits their meaning (shape resembles NCHW/NHWC whereas we only describe HW) → this is more or less a refactoring change only, but it also effects theinput_size
setters for the two parsers (setInputShape
→setInputSize
)The implemented changes were tested on YuNet and Ultra Fast Lane Detection models.