Fix/luxonis dataset converter #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klemen1999
approved these changes
Mar 2, 2025
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results 6 files 6 suites 3h 23m 28s ⏱️ Results for commit 13844bd. ♻️ This comment has been updated with latest results. |
sokovninn
reviewed
Mar 2, 2025
| # if dataset_plugin is set, use that | ||
| if self.dataset_plugin: | ||
| if "GOOGLE_APPLICATION_CREDENTIALS" in os.environ: | ||
| logger.info(f"Using {self.dataset_plugin} dataset") | ||
| dataset_constructor = DATASETS_REGISTRY.get(self.dataset_plugin) | ||
| dataset = dataset_constructor(dataset_name) | ||
| dataset = dataset_constructor( | ||
| dataset_name, delete_existing=True, delete_remote=True |
There was a problem hiding this comment.
delete_existing and delete_remote are not typically present in datasets from the registry.
There was a problem hiding this comment.
But even if it is not typical, isn't better to still have it there, so maybe in the future it might be needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing
LuxonisDatasetconversion.Specification
LuxonisDatasetcreation that isn't compatible with the newLuxonisDatasetschema and indentation of the annotation yielding.Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation