Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Segmentation, Logging, and Dataset Conversion #80

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

sokovninn
Copy link
Member

@sokovninn sokovninn commented Feb 6, 2025

Purpose

This PR introduces multiple improvements and fixes to enhance annotation processing, logging, and dataset conversion.

Specification

  • Fixes:
    • Skip num_objects_range check when no generation is involved.
    • Correct bounding box visualization image ordering.
    • Skip empty segmentation annotations during conversion to coco.
  • Features:
    • Implement segmentation mask smoothing (2x-10x smaller annotation file size).
    • Integrate loguru for enhanced logging capabilities.
    • Update Luxonis dataset converter with latest improvements.
  • Refactor:
    • Rename confidence threshold variable for better readability.

Dependencies & Potential Impact

  • No known breaking changes.

Deployment Plan

  1. Deploy changes to a staging environment for validation.
  2. Monitor possible issues.
  3. Roll out to production.

Testing & Validation

  • Visual validation of segmentation mask smoothing.
  • Logging behavior verified.
  • Dataset conversion tested with sample Luxonis datasets.

@sokovninn sokovninn requested review from HonzaCuhel and a team February 6, 2025 12:22
@sokovninn sokovninn self-assigned this Feb 6, 2025
@sokovninn sokovninn requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team February 6, 2025 12:22
Copy link

github-actions bot commented Feb 6, 2025

Test Results

  6 files    6 suites   3h 31m 36s ⏱️
 79 tests  58 ✅  20 💤 1 ❌
474 runs  344 ✅ 124 💤 6 ❌

For more details on these failures, see this check.

Results for commit c7c2fea.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HonzaCuhel HonzaCuhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🚀🚀

@sokovninn sokovninn merged commit 83bae50 into dev Feb 11, 2025
2 of 9 checks passed
@sokovninn sokovninn mentioned this pull request Feb 14, 2025
@sokovninn sokovninn deleted the feat/misc-improvements branch February 17, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants