examples/lvgldemo: Select default demo #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupyuen
changed the title
The LVGL Example App `lvgldemo` currently requires 1 argument: the name of the demo to show. ```bash lvgldemo widgets ``` In this PR, we propose to make the argument optional if there is only one demo configured. This will enable PINE64 PinePhone to boot straight into `lvgldemo` and auto-start the LVGL App, without entering any `nsh` commands. ### Modified Files `examples/lvgldemo/lvgldemo.c`: If no arguments are specified and only 1 demo exists, select the demo
lupyuen
pushed a commit
that referenced
this pull request
Oct 2, 2024
sed: -e expression #1, char 0: no previous regular expression Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
lupyuen
pushed a commit
that referenced
this pull request
Oct 2, 2024
wdog.c:190:3: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'
#0 0x40e35d3a in wdog_test_run /home/cuiziwei/ska/vela/vela-dev2/apps/testing/ostest/wdog.c:190
#1 0x40e35e75 in wdog_test_thread /home/cuiziwei/ska/vela/vela-dev2/apps/testing/ostest/wdog.c:207
#2 0x40773ffa in pthread_startup pthread/pthread_create.c:59
#3 0x4495e037 in pthread_start pthread/pthread_create.c:139
#4 0x40301864 in pre_start sim/sim_initialstate.c:52
Signed-off-by: cuiziwei <cuiziwei@xiaomi.com>
lupyuen
pushed a commit
that referenced
this pull request
Dec 2, 2024
Applying patch to flatbuffers patching file '<' Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patching file '<' Hunk #1 FAILED at 39. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patching file '<' Hunk #1 FAILED at 495. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patching file '<' Hunk #1 FAILED at 23. 1 out of 1 hunk FAILED -- saving rejects to file '<.rej' patch: **** Can't reopen file '<' : No such file or directory -- Configuring done (12.8s) -- Generating done (0.3s) Signed-off-by: chao an <anchao@lixiang.com>
lupyuen
pushed a commit
that referenced
this pull request
Dec 24, 2024
…ter was read
#0 0x43c7443a in strnlen nuttx/libs/libc/string/lib_strnlen.c:42
#1 0x43c698aa in vsprintf_internal nuttx/libs/libc/stdio/lib_libvsprintf.c:933
#2 0x43c6ca80 in lib_vsprintf nuttx/libs/libc/stdio/lib_libvsprintf.c:1383
#3 0x4409c0bd in vsnprintf nuttx/libs/libc/stdio/lib_vsnprintf.c:72
#4 0x47137cd0 in vcmocka_print_error apps/testing/cmocka/cmocka/src/cmocka.c:2097
#5 0x47139573 in cmocka_print_error apps/testing/cmocka/cmocka/src/cmocka.c:2422
#6 0x471376ff in string_equal_display_error apps/testing/cmocka/cmocka/src/cmocka.c:1410
#7 0x471379a0 in _assert_string_equal apps/testing/cmocka/cmocka/src/cmocka.c:1952
#8 0x4433d972 in read_default apps/testing/drivertest/drivertest_uart.c:242
#9 0x4713c6cd in cmocka_run_one_test_or_fixture apps/testing/cmocka/cmocka/src/cmocka.c:3029
apache#10 0x4713d487 in cmocka_run_one_tests apps/testing/cmocka/cmocka/src/cmocka.c:3143
apache#11 0x4713f2ca in _cmocka_run_group_tests apps/testing/cmocka/cmocka/src/cmocka.c:3294
apache#12 0x443444c6 in cmocka_driver_uart_main apps/testing/drivertest/drivertest_uart.c:358
apache#13 0x4409a472 in nxtask_startup nuttx/libs/libc/sched/task_startup.c:72
apache#14 0x43dc92e7 in nxtask_start nuttx/sched/task/task_start.c:116
apache#15 0x43e31f00 in pre_start nuttx/arch/sim/src/sim/sim_initialstate.c:52
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
lupyuen
pushed a commit
that referenced
this pull request
Dec 24, 2024
Coverity Log CID 1612743: (#1 of 1): Resource leak (RESOURCE_LEAK) 12. leaked_handle: The handle variable fd_out goes out of scope and leaks the handle. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
lupyuen
pushed a commit
that referenced
this pull request
Dec 24, 2024
Coverity Log CID 1612757: (#1 of 1): UNUSED_VALUE assigned_value: The value -1 is assigned to param.fd_in here, but the stored value is overwritten before it can be used. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
lupyuen
pushed a commit
that referenced
this pull request
Jan 20, 2025
…int to a stack space
==1805058==ERROR: AddressSanitizer: heap-use-after-free on address 0xe18126a0 at pc 0x52b06320 bp 0xd7b13ee8 sp 0xd7b13ed8
READ of size 1 at 0xe18126a0 thread T0
#0 0x52b0631f in tre_parse regex/regcomp.c:1356
#1 0x52b2b1d0 in regcomp regex/regcomp.c:3710
#2 0x48f55435 in c_regexmatch cmocka/src/cmocka.c:494
#3 0x48f65bcf in _cmocka_run_group_tests cmocka/src/cmocka.c:3252
#4 0x48f67e2d in cmocka_fs_test_main apps/testing/testsuites/kernel/fs/cmocka_fs_test.c:201
#5 0x46210b2a in nxtask_startup sched/task_startup.c:72
#6 0x45ff40fb in nxtask_start task/task_start.c:116
#7 0x462695bb in pre_start sim/sim_initialstate.c:52
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The LVGL Example App
lvgldemocurrently requires 1 argument: the name of the demo to show.In this PR, we propose to make the argument optional if there is only one demo configured. This will enable PINE64 PinePhone to boot straight into
lvgldemoand auto-start the LVGL App, without entering anynshcommands.Modified Files
examples/lvgldemo/lvgldemo.c: If no arguments are specified and only 1 demo exists, select the demoImpact
With this PR,
lvgldemowill no longer require an argument if there is only one demo configured. So this command:Is equivalent to
lvgldemo widgetsif there is only one demowidgetsconfigured.If there is more than one demo configured, or if an argument is provided,
lvgldemowill work the same way as before.Testing
We successfully tested
lvgldemowith a Single Configured Demo:(See the Test Log)
And we tested
lvgldemowith Multiple Configured Demos:(See the Test Log)
Also we verified that PinePhone boots successfully to the
lvgldemo widgetsdemo automatically, without entering anynshcommands. We configured the PinePhone build as follows:RTOS Features > Tasks and Scheduling
Set "Application entry point" to
lvgldemo_main(INIT_ENTRYPOINT)
Set "Application entry name" to
lvgldemo_main(INIT_ENTRYNAME)
Application Configuration > NSH Library
Disable "Have architecture-specific initialization"
(NSH_ARCHINIT)