Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add react package #4

Merged
merged 3 commits into from
Jun 13, 2020
Merged

feat: Add react package #4

merged 3 commits into from
Jun 13, 2020

Conversation

johnletey
Copy link
Member

Based off of react-feather

Icons are pulled from the main ./icons directory (this is where we differ from react-feather, which is dependent on the published JS library), and transformed into functions to be published.

I've also added Yarn Workspaces, which simplifies everything in general, as well as allows us to deploy #1.

I've moved the JS library code to a folder. I'll refactor this in a later PR :)

@johnletey johnletey mentioned this pull request Jun 13, 2020
@moeenio
Copy link
Contributor

moeenio commented Jun 13, 2020

I'm not good with React and stuff, so merge if you wish. 👍

@johnletey
Copy link
Member Author

so merge if you wish

I'm gonna go ahead and do that 👍 There's probably some things missing for deploying the package, but that's for the future once we think of a name 😄

@johnletey johnletey merged commit d652e79 into master Jun 13, 2020
@johnletey johnletey deleted the feat/react branch June 13, 2020 11:52
ericfennis added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants