Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): adds scan-document icon #2882

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maksimetny
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds a scan-document icon

Icon use case

This icon can be useful as a visual representation of a document or file being scanned

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: scan & file-text
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Copy link

github-actions bot commented Mar 8, 2025

Added or changed icons

icons/scan-document.svg

Preview cohesion icons/square-check.svg
icons/scan-document.svg
icons/monitor-smartphone.svg
Preview stroke widths icons/scan-document.svg
icons/scan-document.svg
icons/scan-document.svg
DPI Preview (24px) icons/scan-document.svg
Icon X-rays icons/scan-document.svg
Icon Diffs icons/scan-document.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ScanDocumentIcon = createLucideIcon('ScanDocument', [
  ["path",{"d":"M2 18V22H6M2 6V2H6M22 6V2H18M18 22H22V18M18 10V17C18 18.1046 17.1046 19 16 19H8C6.89543 19 6 18.1046 6 17V7C6 5.89543 6.89543 5 8 5H13M18 10H15C13.8954 10 13 9.10457 13 8V5M18 10V9L14 5H13M9 16H15M15 13H9M9 10H10"}]
])

@UsamaKhan
Copy link

There is already a file-scan icon that could be used.

Irrespective of that, there are a couple issue with the icon. The spacing is too tight in multiple spots. There needs to be 2 px spacing around the strokes. If you were to properly space out the icon, you wouldn't be able to fit the "file text lines" in the icon.

Also, the scanner part of the icon isn't in line with the other scan-* icons so it doesn't feel in place.

I created a version that has proper spacing and consistency with the other icons:

icons
Open lucide studio

As you can see, it's pretty tight so you cant really fit anything in the file icon.

@maksimetny
Copy link
Author

There is already a file-scan icon that could be used.

Irrespective of that, there are a couple issue with the icon. The spacing is too tight in multiple spots. There needs to be 2 px spacing around the strokes. If you were to properly space out the icon, you wouldn't be able to fit the "file text lines" in the icon.

Also, the scanner part of the icon isn't in line with the other scan-* icons so it doesn't feel in place.

I created a version that has proper spacing and consistency with the other icons:

iconsOpen lucide studio

As you can see, it's pretty tight so you cant really fit anything in the file icon.

The file-scan icon you mentioned does not fully capture the essence of my idea, as I am not "scanning a file" but rather scanning a physical document
Your version reflects this semantics well and looks good, but the overly small depiction of a "document" in center makes it resemble a sticker more, which reduces readability
I would also like to draw your attention to the fact that this package already includes icons with padding 1px or uneven proportions

Overall, your version has a right to exist 👍

@jguddas
Copy link
Member

jguddas commented Mar 11, 2025

icons
Open lucide studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants