Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add screen-share icons #28

Merged
merged 6 commits into from
Jun 28, 2020
Merged

feat: Add screen-share icons #28

merged 6 commits into from
Jun 28, 2020

Conversation

johnletey
Copy link
Member

@johnletey johnletey commented Jun 26, 2020

Screenshot 2020-06-28 at 11 35 20

Closes #26.

@dgdavid
Copy link

dgdavid commented Jun 26, 2020

Wow! You're awesome. I didn't expect to see a pr/proposal right today. Thanks a lot.

If you don't mind, I have some thoughts / suggestions.

  • What about placing the up-arrow more vertically centered in the start-screenshare-2? How it looks closing a bit the "gap" in the top border of the monitor?

  • Should we use, for consistence, the Feather/-off style for the stop versions? I mean, using the same start version but crossed out.

    See the Feather/mic-off.

    Screenshot_2020-06-26 Feather – Simply beautiful open source icons

Have a nice weekend!

@dgdavid
Copy link

dgdavid commented Jun 26, 2020

  • Should we use, for consistence, the Feather/-off style for the stop versions? I mean, using the same start version but crossed out.

Also for consistence, screen-share and screen-share-off could be good names.

@moeenio
Copy link
Contributor

moeenio commented Jun 26, 2020

discord vibes

@johnletey
Copy link
Member Author

discord vibes

@locness3 That's exactly what I was going for 😁

screen-share and screen-share-off could be good names.

Yeah I like that!

  • using the same start version but crossed out.

I personally think the arrow and x are better.

@johnletey johnletey changed the title feat: Add screenshare icons feat: Add screen-share icons Jun 27, 2020
@lscheibel
Copy link
Member

I really like the ones with the symbol in the corner

@johnletey
Copy link
Member Author

@lscheibel Same! Those are my favourites. Maybe we should just add those?

@ericfennis
Copy link
Member

I think the arrow and the x are better too.
The x presents more "disconnect" I think.

But maybe we can add them in the future as wel!

@johnletey
Copy link
Member Author

johnletey commented Jun 28, 2020

I removed the second variations of the icons for now. They didn't really represent screen-sharing to me. The current ones do though.

If it's okay with everyone think we can merge this 🚀

@johnletey johnletey merged commit 456b54c into master Jun 28, 2020
@johnletey johnletey deleted the feat/screenshare branch June 28, 2020 13:56
@dgdavid
Copy link

dgdavid commented Jun 28, 2020

I think the arrow and the x are better too.
The x presents more "disconnect" I think.

Sure, you both are right. Thinking about "disconnecting" the stream has more sense in that context than "powering it off".

Anyway, I was just suggesting ideas, since rght now it is the only way I can contribute.

But maybe we can add them in the future as wel!

Let's see ;)

@johnletey
Copy link
Member Author

I was just suggesting ideas, since rght now it is the only way I can contribute.

Yeah, we are grateful for your input and ideas, keep it up! 🖤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: start/stop sharing screen
5 participants