-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add screen-share
icons
#28
Conversation
Wow! You're awesome. I didn't expect to see a pr/proposal right today. Thanks a lot. If you don't mind, I have some thoughts / suggestions.
Have a nice weekend! |
Also for consistence, |
discord vibes |
@locness3 That's exactly what I was going for 😁
Yeah I like that!
I personally think the arrow and x are better. |
I really like the ones with the symbol in the corner |
@lscheibel Same! Those are my favourites. Maybe we should just add those? |
I think the arrow and the x are better too. But maybe we can add them in the future as wel! |
I removed the second variations of the icons for now. They didn't really represent screen-sharing to me. The current ones do though. If it's okay with everyone think we can merge this 🚀 |
Sure, you both are right. Thinking about "disconnecting" the stream has more sense in that context than "powering it off". Anyway, I was just suggesting ideas, since rght now it is the only way I can contribute.
Let's see ;) |
Yeah, we are grateful for your input and ideas, keep it up! 🖤 |
Closes #26.