Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise/add missing calendar[-*] icons/improve metadata #1377

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

danielbayley
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Added or changed icons

icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg

Preview cohesion icons/play-square.svgicons/terminal-square.svgicons/message-square-heart.svgicons/parking-square.svgicons/arrow-down-square.svgicons/m-square.svgicons/pi-square.svgicons/message-square-diff.svgicons/chevron-left-square.svgicons/slash-square.svgicons/power-square.svgicons/messages-square.svgicons/mouse-pointer-square.svgicons/message-square-more.svgicons/message-square-reply.svgicons/menu-square.svg
icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg
icons/ticket.svgicons/washing-machine.svgicons/x.svgicons/feather.svgicons/file-spreadsheet.svgicons/align-vertical-justify-center.svgicons/battery-warning.svgicons/arrow-down-left-from-circle.svgicons/shield-question.svgicons/panel-left-close.svgicons/arrow-down.svgicons/git-compare.svgicons/haze.svgicons/trash-2.svgicons/scan-face.svgicons/arrow-up-0-1.svg
Preview stroke widths icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg
icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg
icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg
DPI Preview (24px) icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg
Icon X-rays icons/calendar-fold.svgicons/calendar-minus-2.svgicons/calendar-plus-2.svgicons/calendar-check-2.svgicons/calendar-check.svgicons/calendar-clock.svgicons/calendar-days.svgicons/calendar-heart.svgicons/calendar-minus.svgicons/calendar-off.svgicons/calendar-plus.svgicons/calendar-range.svgicons/calendar-search.svgicons/calendar-x-2.svgicons/calendar-x.svgicons/calendar.svg

@danielbayley danielbayley changed the title Optimise/add missing calendar[-*] icons Optimise/add missing calendar[-*] icons/improve metadata Jun 21, 2023
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on optimizing the SVG paths.
Can you describe the use cases for newly added icons?

@danielbayley
Copy link
Member Author

Can you describe the use cases for newly added icons?

@ericfennis Sure, so calendar-[plus/minus]-2 are obviously currently missing variants of https://lucide.dev/icons/calendar-plus and https://lucide.dev/icons/calendar-minus. calendar-slash is date marked/past or busy/future planned event etc… calendar-fold is like next month/look ahead (as if you were to flip to the next page), but can also be bookmark, as folding the corner is an easy way of doing that. Also matches the fold from sticky-note/file etc… (See #1378).

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 24, 2023
@danielbayley danielbayley requested a review from ericfennis August 1, 2023 21:21
@danielbayley danielbayley mentioned this pull request Aug 1, 2023
@github-actions github-actions bot removed the Stale label Jan 8, 2024
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 22, 2024
@ericfennis
Copy link
Member

I've removed the calendar-slash icon, the usecase is a bit questionable also since it is proposed in your other icon PRs. We can still add them to the lab branch if you want.

@ericfennis ericfennis merged commit 06372db into lucide-icons:main Jan 22, 2024
6 checks passed
@danielbayley danielbayley deleted the calendar branch January 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants