ci(actions): Update & cleanup actions (#2764)

* Update actions * Update workflows * Remove double jobs
lucide-icons · Feb 28, 2025 · 3c23331 · 3c23331
1 parent 5a7c49d
commit 3c23331
Show file tree

Hide file tree

Showing 21 changed files with 142 additions and 250 deletions.
diff --git a/.github/actions/build-and-test.yml b/.github/actions/build-and-test.yml
diff --git a/.github/actions/check-icons.yml b/.github/actions/check-icons.yml
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,10 +16,9 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies

diff --git a/.github/workflows/close-issue-with-banned-phrases.yml b/.github/workflows/close-issue-with-banned-phrases.yml
@@ -11,7 +11,7 @@ jobs:
       issues: write
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Check for blocked phrases in issue title
         run: |

diff --git a/.github/workflows/pull-request.yml → .github/workflows/linting-icons.yml b/.github/workflows/pull-request.yml → .github/workflows/linting-icons.yml
@@ -1,58 +1,55 @@
-name: Add Changed Icons comment
+name: Linting Icons
 
 on:
-  pull_request_target:
+  pull_request:
     paths:
       - 'icons/*'
-    branches:
-      - main
-      - fix-icon-preview
 
 jobs:
   lint-filenames:
+    name: Lint Filenames
     if: github.repository == 'lucide-icons/lucide'
     runs-on: ubuntu-latest
     permissions:
       contents: read
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          ref: refs/pull/${{ github.event.pull_request.number }}/merge
       - name: Get changed files
         id: changed-files
         uses: tj-actions/changed-files@v41
         with:
           files: icons/*
+
       - name: Generate annotations
         run: node ./scripts/lintFilenames.mjs
         env:
           CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
 
   lint-contributors:
+    name: Lint Contributors
     if: github.repository == 'lucide-icons/lucide'
     runs-on: ubuntu-latest
     permissions:
       contents: read
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          ref: refs/pull/${{ github.event.pull_request.number }}/merge
       - name: Get changed files
         id: changed-files
         uses: tj-actions/changed-files@v41
         with:
           files: icons/*
+
       - uses: actions/setup-node@v4
       - name: Install simple-git (safer and faster than installing all deps)
         run: npm install simple-git
+
       - name: Generate annotations
         run: node ./scripts/updateContributors.mjs
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           FETCH_DEPTH: ${{ github.event.pull_request.commits }}
           CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
+
       - name: Generate annotations
         env:
           ANNOTATION_SEVERITY: notice
@@ -77,47 +74,3 @@ jobs:
       - uses: actions/checkout@v4
       - name: Check Uniqueness of Aliases
         run: "! cat <(printf \"%s\\n\" icons/*.json | while read -r name; do basename \"$name\" .json; done) <(jq -cr 'select(.aliases) | .aliases[] | if type==\"string\" then . else .name end' icons/*.json) | sort | uniq -c | grep -ve '^\\s*1 '"
-
-  generate-changed-icons-comment:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      pull-requests: write
-
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          ref: refs/pull/${{ github.event.pull_request.number }}/merge
-
-      - name: Get changed files
-        id: changed-files
-        uses: tj-actions/changed-files@v41
-        with:
-          files: icons/*.svg
-
-      - name: Find Comment
-        uses: peter-evans/find-comment@v2
-        id: pr-comment
-        with:
-          issue-number: ${{ github.event.pull_request.number }}
-          comment-author: 'github-actions[bot]'
-          body-includes: Added or changed icons
-
-      - uses: actions/setup-node@v4
-      - name: Install svgson for code preview (safer and faster than installing all deps)
-        run: npm install svgson
-
-      - name: Generate comment markup
-        run: node ./scripts/generateChangedIconsCommentMarkup.mjs >> comment-markup.md
-        id: comment-markup
-        env:
-          CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
-
-      - name: Create or update comment
-        uses: peter-evans/create-or-update-comment@v3
-        with:
-          comment-id: ${{ steps.pr-comment.outputs.comment-id }}
-          issue-number: ${{ github.event.pull_request.number }}
-          body-path: ./comment-markup.md
-          edit-mode: replace
diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -1,23 +1,44 @@
-name: Linting
+name: Linting PR
 
 on:
   pull_request:
     branches:
       - '**'
 
 jobs:
-  linting:
+  lint-code:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile
 
       - name: Run Linter
         run: pnpm lint
+
+  lint-PR-title:
+    name: PR Title Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: amannn/action-semantic-pull-request@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          types: |
+            fix
+            feat
+            perf
+            refactor
+            test
+            style
+            docs
+            ci
+            build
+          requireScope: true
+          ignoreLabels: |
+            bot
diff --git a/.github/workflows/lucide-angular.yml b/.github/workflows/lucide-angular.yml
@@ -12,10 +12,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies
@@ -27,11 +26,10 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3.8.1
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies

diff --git a/.github/workflows/lucide-font.yml b/.github/workflows/lucide-font.yml
@@ -12,10 +12,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies
@@ -28,7 +27,7 @@ jobs:
         run: pnpm build:font
 
       - name: 'Upload to Artifacts'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: lucide-font
           path: lucide-font
diff --git a/.github/workflows/lucide-preact.yml b/.github/workflows/lucide-preact.yml
@@ -14,10 +14,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies

diff --git a/.github/workflows/lucide-react-native.yml b/.github/workflows/lucide-react-native.yml
@@ -10,14 +10,28 @@ on:
       - pnpm-lock.yaml
 
 jobs:
-  lucide-react-native:
+  build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v4
+        with:
+          cache: 'pnpm'
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Build
+        run: pnpm --filter lucide-react-native build
+
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies

diff --git a/.github/workflows/lucide-react.yml b/.github/workflows/lucide-react.yml
@@ -15,10 +15,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies
@@ -30,11 +29,10 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: pnpm/action-setup@v2
-      - uses: actions/setup-node@v3.8.1
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
           cache: 'pnpm'
 
       - name: Install dependencies