Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantifying wildcard - breaking change #50

Open
C0rn-Fl4k3s opened this issue Jul 3, 2024 · 4 comments
Open

quantifying wildcard - breaking change #50

C0rn-Fl4k3s opened this issue Jul 3, 2024 · 4 comments

Comments

@C0rn-Fl4k3s
Copy link

Please revert your change with "quantifying wildcard" which say to use the synthax "$$count#wildcards".
This is a breaking change for me who write and publish wildcards, specially since this a diverging implementation from wildcard plugins for other web-ui such as https://github.com/adieyal/sd-dynamic-prompts/blob/main/docs/SYNTAX.md

The result is this prompt won't call twice the wildcard as it did before:
{2$$cornf-fantasy-house/surrounding}

By the way the new synthax does not work as intended, or it is not intuitive, or the example given in the documentation is wrong :
{2$$, $$5#wildcards} turns into {2$$, $$wildcards|wildcards|wildcards|wildcards|wildcards}

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 3, 2024

{2$$, $$5#wildcards} is functioning as intended.
Due to 5#wildcards, 'wildcards' is repeated 5 times, becoming wildcards|wildcards|wildcards|wildcards|wildcards,
and {2$$, $$} selects 2 items from the options and concatenates them with a comma.

i.e. it is populated to wildcards, wildcards

It's just that some parts of the documentation are incorrect. It should be count#wildcards instead of $$count#wildcards.

https://github.com/ltdrdata/ComfyUI-extension-tutorials/blob/Main/ComfyUI-Impact-Pack/tutorial/ImpactWildcard.md#syntax

{<count>$$<single wildcard option>} syntax is a grammar that has never been supported. If it seemed to work that way, it was a bug.

@ltdrdata
Copy link
Owner

ltdrdata commented Jul 3, 2024

Btw, I updated Impact Pack to support {<count>$$<single wildcard option>} pattern.

@C0rn-Fl4k3s
Copy link
Author

Thanks a lot :3

@C0rn-Fl4k3s C0rn-Fl4k3s reopened this Jul 15, 2024
@C0rn-Fl4k3s
Copy link
Author

Sorry for coming back on this issue, would it be possible to add a "comma" by default as a separator ? I feel like it was forgotten ^^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants