Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks and resolve numpydoc issue #20

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

jonathansick
Copy link
Member

  • Update pre-commit hooks to work around a isort+poetry issue
  • Work around a new docstring parsing issue in the SubjectCache.insert docstring.

This resolves an issue with isort and poetry.
The error was that the docstring ended without a blank line; this seems
to be a new issue with the sphinx/autodoc/napoleon toolchain. However
moving the note to the extended summary seems to by-pass the issue.
@jonathansick jonathansick merged commit d6c4ba4 into main Feb 23, 2023
@jonathansick jonathansick deleted the u/jonathansick/precommit-update branch February 23, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant