Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I help? #10

Closed
xs005 opened this issue Jun 14, 2020 · 1 comment · Fixed by #11
Closed

How can I help? #10

xs005 opened this issue Jun 14, 2020 · 1 comment · Fixed by #11

Comments

@xs005
Copy link

xs005 commented Jun 14, 2020

I like this async kafka package.

I guess I think something wrong at manager.py line 96. I changed it to schema["name"] = f'{schema["name"]}{self._suffix}'

I am a new developer, where can I create a ticket and corresponding branch if I want to help?

jonathansick added a commit that referenced this issue Jun 15, 2020
Much thanks to @xs005 for spotting this!

Fixes #10
@jonathansick
Copy link
Member

Hi @xs005 thanks for spotting this! Clearly I need to do more testing 😄 I went ahead and pushed a fix and released a new beta, 0.2.0b3 to PyPI so you can use this fixed version more easily.

Feel free to send PRs using GitHub's usual system. As a contributor outside LSST/Rubin Observatory, you can name the branch as you please and submit a PR. We'll take care of reviewing and merging it. Don't worry about tickets in our Jira system.

This page in our docs explains the particular steps for developing Kafkit.

Again, thanks so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants