Make sure deleted object's entries are removed from object_types #1284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
YARD::RegistryStore#delete
removes an object entry from@store
but does not remove its entry from@object_types
.Therefore, some elements of
YARD::Registry.all
may benil
after an object deletion such as the following code.This PR makes sure that
YARD::RegistryStore#delete
remove the deleted object's entry from@object_types
to fix this behavior.Completed Tasks
bundle exec rake
locally (if code is attached to PR).