Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/puzpuzpuz/xsync from 1.4.3 to 1.5.2 #20

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2022

Bumps github.com/puzpuzpuz/xsync from 1.4.3 to 1.5.2.

Release notes

Sourced from github.com/puzpuzpuz/xsync's releases.

v1.5.2

  • Use all available bits in map top hashes (#54)

v1.5.1

  • Expose built-in string hash function (#51)
  • Reduce map bucket size to 1CL (#52)

v1.5.0

  • Support arbitrary comparable keys in MapOf (#49)
    • This became possible due to combining top hash caching with bucket chaining (#48)
  • Add LoadOrCompute method to Map and MapOf (#50)

Thanks @​iamcalledrob for the contribution.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/puzpuzpuz/xsync](https://github.com/puzpuzpuz/xsync) from 1.4.3 to 1.5.2.
- [Release notes](https://github.com/puzpuzpuz/xsync/releases)
- [Commits](puzpuzpuz/xsync@v1.4.3...v1.5.2)

---
updated-dependencies:
- dependency-name: github.com/puzpuzpuz/xsync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 24, 2022
@lrstanley lrstanley merged commit 10092c8 into master Oct 26, 2022
@lrstanley lrstanley deleted the dependabot/go_modules/github.com/puzpuzpuz/xsync-1.5.2 branch October 26, 2022 00:36
@rubiojr
Copy link

rubiojr commented Nov 7, 2022

@lrstanley 👋! FYI this broke master builds, looks like xsync changed API from 1.4.3 to 1.5.2.

internal/lookup/service.go:26:17: got 1 arguments but 2 type parameters
internal/lookup/service.go:38:13: cannot use xsync.NewMapOf[*maxminddb.Metadata]() (value of type *xsync.MapOf[string, *maxminddb.Metadata]) as type *xsync.MapOf[*maxminddb.Metadata] in struct literal
internal/lookup/service.go:48:27: cannot use dbType (variable of type string) as type K in argument to s.Metadata.Load
internal/lookup/service.go:50:17: m.Languages undefined (type V has no field or method Languages)

Reverting fixes it (go get github.com/puzpuzpuz/xsync@v1.4.3), haven't looked into what it'd take to adopt the new version.

@lrstanley
Copy link
Owner

Just pushed the revert @ b1eb60a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants