Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Broken tSQLt test for data sensitivity classification in sp_doc #177

Closed
lowlydba opened this issue Dec 17, 2020 · 1 comment · Fixed by #178
Closed

[Bug] Broken tSQLt test for data sensitivity classification in sp_doc #177

lowlydba opened this issue Dec 17, 2020 · 1 comment · Fixed by #178
Labels
bug Something isn't working

Comments

@lowlydba
Copy link
Owner

Describe the bug
For an unknown reason, when running the (now commented out) unit test for sp_doc regarding data sensitivity classifications, the query always times out (up to 10 minutes) in appveyor.

To Reproduce
I can't reproduce it locally OR when RDP'd into the Appveyor machine, but will try the latter again in a dedicated branch. Might have to do with a recent CU applied to 2019?

Expected behavior
The unit test runs in a reasonable amount of time (few seconds).

Versions(please complete the following information):

  • OS: Windows
  • SQL Server: 2019
  • SSMS: N/A

Additional context
It used to work and nothing in that particular test has changed recently.
@lowlydba lowlydba added the bug Something isn't working label Dec 17, 2020
lowlydba added a commit that referenced this issue Dec 17, 2020
@lowlydba
sp_doc: add indexes (#176)
2dfc2cc 
*  add `<br>` to safe list for markdown linter
* improve some variable naming and data type usage
* add view/table indexes + tests
* upgrade pester to 5.1.0+
* add timeouts to unit test calls
* remove buggy sensitivity classification test (#177 )
@lowlydba lowlydba mentioned this issue Dec 18, 2020
Merged
7 tasks
@lowlydba lowlydba linked a pull request Dec 18, 2020 that will close this issue
fix broken data sensitivity classification test #178
Merged
7 tasks
@lowlydba
Copy link
Owner Author

See the pull request for details on this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix broken data sensitivity classification test lowlydba/dba-multitool
1 participant
@lowlydba