Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add withIcc command to override input file ICC profile #550

Closed
wants to merge 1 commit into from
Closed

add withIcc command to override input file ICC profile #550

wants to merge 1 commit into from

Conversation

mhirsch
Copy link
Contributor

@mhirsch mhirsch commented Aug 23, 2016

This PR adds a withIcc() command which overrides the input ICC profile.

I think the unit test is not quite sufficient, as the difference between the colorspace transformed image and the original input image are very subtle (the RGB values differ by 1 or 2 in most cases) with the ICC profile I'm using. fixtures.assertSimilar() will miss the difference if no transform occurred. The Bluish.icc file was taken from the lcms project via colord. I wonder if there's an ICC profile that would create a more dramatic difference? I hesitate to do something like an assert.strictEqual() on a couple of pixels of the image, as different systems might have different rounding errors during the colorspace conversion.

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage increased (+0.009%) to 99.038% when pulling 59f2da9 on mhirsch:withIcc into 7c06a48 on lovell:master.

@lovell
Copy link
Owner

lovell commented Sep 2, 2016

Hello, there's been some previous discussion in #218 about adding the ability to inject an ICC profile via the existing withMetadata operation. I'll attempt to update it with some thoughts on what the API might look like.

@lovell
Copy link
Owner

lovell commented Dec 7, 2017

Hello, thank you for your time on this so far. I'm going to close this PR as it has drifted a long way behind the master branch - let's use #218 to track improvements.

@lovell lovell closed this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants