add skipBlanks support for dz and zoomify layout #1687
Conversation
|
Bonjour Jordan, merci beaucoup for this PR, which from a quick scan looks good - thank you for adding tests! I notice there's some logic in libvips that defaults This PR will have to wait until after libvips v8.8.0 is released, which sharp will probably pick up in v0.23.0. I'll fix up the tests at that point to reflect the new/changed features that are making them fail. |
|
Hi, I've fixes this part and added a test to the google layout. let me know if you see any improvement :) |
|
@RaboliotTheGrey I've changed the destination branch for this PR to the |
|
Thanks!
I wont be able to rebase it until thuesday. :)
Have a nice week-end
…-------- Original Message --------
On 6 Jul 2019, 14:52, Lovell Fuller wrote:
***@***.***(https://github.com/RaboliotTheGrey) I've changed the destination branch for this PR to the vision branch, which will become v0.23.0. Are you able to rebase against the vision branch and push to allow the CI tests to pass?
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#1687?email_source=notifications&email_token=AD3HJ7RWIIHPGEHAGHXGKLDP6CIRZA5CNFSM4HKTI3I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKZD4Y#issuecomment-508924403), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AD3HJ7QAV2UESO6MP5U43KTP6CIRZANCNFSM4HKTI3IQ).
|
|
Hi, I've rebase the branch on the lastest version of vision and test agains the version 8.8.1 of libvips. |
lib/output.js
Outdated
| @@ -539,6 +539,7 @@ function toFormat (format, options) { | |||
| * @param {Number} [tile.overlap=0] tile overlap in pixels, a value between 0 and 8192. | |||
| * @param {Number} [tile.angle=0] tile angle of rotation, must be a multiple of 90. | |||
| * @param {String} [tile.depth] how deep to make the pyramid, possible values are `onepixel`, `onetile` or `one`, default based on layout. | |||
| * @param {Number} [tile.skipBlank=-1] threshold to skip tile generation, a value 0 - 255 for 8-bit images or 0 - 65535 for 16-bit images | |||
There was a problem hiding this comment.
I think tile.skipBlank should be the plural form tile.skipBlanks.
Please can you run npm run docs after fixing this, which should automagically update docs/api-output.md.
There was a problem hiding this comment.
Nice catch :)
Sorry I took a bit long to fix this.
|
Merveilleux, merci beaucoup. |
Hi!
Here it is !
Image metadata -> JPEG with IPTC/XMPandAttention strategy -> JPEG) It also appears with master when libvips 8.8.0 is activated. I didn't fix them because i don't underestand their purposes ...AttrTo<int32_t>(options, "skipBlanks")return 0 if it's NULL/undefinedLet me know if it needs some modifications.