Enhancement: silently ignore embedded ICC profile with invalid PCS illuminant, will downgrade "Couldn't link the profiles" from error to warning

[martinj]

Possible bug

Is this a possible bug in a feature of sharp, unrelated to installation?

• Running npm install sharp completes without error.
• Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.

Are you using the latest version of sharp?

• I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.

If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.

What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?

  System:
    OS: macOS 13.4.1
    CPU: (12) arm64 Apple M2 Max
    Memory: 1.86 GB / 96.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
  npmPackages:
    sharp: ^0.33.0 => 0.33.0

What are the steps to reproduce?

Try to do any conversion using withMetadata() on the image will result in VipsIcc: Couldn't link the profiles error

I've tracked the issue down to 0.32.5, versions below works fine.

What is the expected behaviour?

That it succeeds without error

Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem

const sharp = require('sharp');
sharp('1.jpg').withMetadata().toFile('out.jpg').catch(console.error);

Please provide sample image(s) that help explain this problem

[lovell]

The ICC profile embedded in this image is invalid as the PCS illuminant does not have the standard/required value of 50. Inspecting the binary data suggests the value might be 0xd32c, which doesn't look right at all. The description is "AppleVision 1710 - 9300", which suggests this profile is probably around 25 years old.

I suspect a recent improvement in the underlying lcms2 is preventing the use of this profile, and you can use the ignoreIcc constructor option to do just that.

sharp('1.jpg', { ignoreIcc: true })...

[martinj]

Since I discovered this while using a global custom build of vips I initially thought this was related to the version of lcms2 I used, however using same global vips build for sharp 0.32.4 it works, which make me think the change seems to come from sharp.

Did not know of ignoreIcc guess i could use that to work around it. Thank you.

[lovell]

Thanks, this probably relates to commit bb7469b

Perhaps sharp should silently ignore the invalid profile, although the output might then be incorrect. Are you able to grant permission for me to add this image to sharp's test corpus if so?

If you're using v0.33.0, you might want to use the new withIccProfile() instead of withMetadata() for more fine-grained control over output profile.

https://sharp.pixelplumbing.com/api-output#withiccprofile

[martinj]

Perhaps sharp should silently ignore the invalid profile, although the output might then be incorrect

In my case that would be great!

Are you able to grant permission for me to add this image to sharp's test corpus if so?

That specific image i don't own the rights to. However I've produced a similar image with the same issue which you are free to use

If you're using v0.33.0, you might want to use the new withIccProfile() instead of withMetadata() for more fine-grained control over output profile.

Thank you for pointing this out, thats a great addition.

[lovell]

v0.33.1 now available with this enhancement.