Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for io.js v3 (and therefore Node v4) #246

Closed
lovell opened this issue Aug 5, 2015 · 6 comments
Closed

Add support for io.js v3 (and therefore Node v4) #246

lovell opened this issue Aug 5, 2015 · 6 comments

Comments

@lovell
Copy link
Owner

lovell commented Aug 5, 2015

Placeholder to track the upgrade to the new version of io.js/V8 and all the nan changes this will require.

This requires comprehensive memory leak and Buffer performance checks.

@lovell
Copy link
Owner Author

lovell commented Aug 9, 2015

V8 seems to have jumped on the monad bus with the (Haskell-inspired?) MaybeLocal type. This forces explicit exception handling, a good thing, but it does mean a fairly big code change to the marshalling of data between V8 and native C types.

@lovell lovell added this to the v0.12.0 milestone Aug 12, 2015
@lovell lovell changed the title Add support for io.js v3 Add support for io.js v3 (and therefore Node v4) Aug 12, 2015
@mahnunchik
Copy link

I've allowed failures in gulp-responsive for iojs v3 for a while: https://github.com/mahnunchik/gulp-responsive/blob/master/.travis.yml#L7-L9

lovell added a commit that referenced this issue Aug 23, 2015
Provides support for io.js v3 and Node v4
lovell added a commit that referenced this issue Aug 23, 2015
Provides support for io.js v3 and Node v4
@lovell
Copy link
Owner Author

lovell commented Aug 23, 2015

The work-in-progress branch for this can be tested via npm install lovell/sharp#nan2

Everything compiles and the functional tests pass using io.js v3.1.0.

I have yet to run the leak checks (will probably require additional suppression rules for new V8 API) or used the benchmarks to measure the effects, if any, of recent changes to the Buffer object.

lovell added a commit that referenced this issue Aug 23, 2015
Provides support for io.js v3 and Node v4
@lovell
Copy link
Owner Author

lovell commented Aug 24, 2015

Leak checks run on Node.js v0.12.7, io.js v2.5.0 and v3.1.0.

Changes were required - see 4e67a50

@lovell lovell modified the milestones: v0.11.2, v0.12.0 Aug 24, 2015
@lovell
Copy link
Owner Author

lovell commented Aug 24, 2015

Benchmarks run using Node.js v0.12.7 and io.js v3.1.0.

There's no statistically significant performance impact - (de)compression I/O is still the bottleneck.

@lovell
Copy link
Owner Author

lovell commented Aug 24, 2015

Support for io.js v3 now in master - this will be published to npm as part of v0.11.2.

@lovell lovell closed this as completed Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants