-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed error #204
Comments
Flatten seems to resolve the issue:
|
Looks like a bug, thanks for reporting this. I'll try to add a test case to confirm this later today. Were you hoping to preserve transparency in the output image? |
I've reproduced this @mikemliu. It occurs when embedding an image with an alpha channel onto any background colour that does not have a transparency, which includes the default. I've added a new test case to expose the failure and the fix in commit 33782d3. Are you able to retest via |
I realized the same when I actually put in my desired transparent background. Thanks! |
@mikemliu Were you able to confirm this fix solved the problem? If so I'll publish a point release with it to npm. |
confirmed. thanks! |
This is fixed in v0.10.1, now available via npm. |
Getting an error embedding png with transparency on the default black background (inside larger background canvas)
start with a 50x50 png with alpha channel:
i get the following:
The following DO work:
The text was updated successfully, but these errors were encountered: